Re: [quicwg/base-drafts] One close frames (#1900)
Mike Bishop <notifications@github.com> Mon, 29 October 2018 21:41 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D87AD130FB8 for <quic-issues@ietfa.amsl.com>; Mon, 29 Oct 2018 14:41:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id s5uhlebGfxAJ for <quic-issues@ietfa.amsl.com>; Mon, 29 Oct 2018 14:41:31 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1A17A127133 for <quic-issues@ietf.org>; Mon, 29 Oct 2018 14:41:31 -0700 (PDT)
Date: Mon, 29 Oct 2018 14:41:29 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1540849289; bh=EhPx24iDCit1fvoIiZDX/gXaozoj+H5yzKOWfsjSqW8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=zldessZ7F3wiqarjB4l6Qg5BruG6w/fJR4dQUY/C8QE9eoxxzhbCMXgEiITLmZzFK ZBBapaG268+j0yURCL7Pwun+PsKpTcOYa4Jzb0VwTPCIwZ7zxONazMChZWgADQNdS1 SqonuUquRCPOt1SeOxpKTbN7Opx0dBnIBKnxViwA=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab3c6495c36d626c47369bd72a8a3c9ab266ba0c8192cf0000000117ef408992a169ce164012de@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1900/review/169530983@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1900@github.com>
References: <quicwg/base-drafts/pull/1900@github.com>
Subject: Re: [quicwg/base-drafts] One close frames (#1900)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bd77e89d8b44_502c3fb6d18d45c4148758"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/m81bFxMTf2MP52HZfu2ZZgC_E_M>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Oct 2018 21:41:34 -0000
MikeBishop commented on this pull request. > @@ -2228,28 +2230,28 @@ Note: control, which are not expected to be relevant for a closed connection. Retransmitting the final packet requires less state. -After receiving a closing frame, endpoints enter the draining state. An -endpoint that receives a closing frame MAY send a single packet containing a -closing frame before entering the draining state, using a CONNECTION_CLOSE frame -and a NO_ERROR code if appropriate. An endpoint MUST NOT send further packets, -which could result in a constant exchange of closing frames until the closing -period on either peer ended. +After receiving a CONNECTION_CLOSE frame, endpoints enter the draining state. +An endpoint that receives a CONNECTION_CLOSE frame MAY send a single packet +containing a CONNECTION_CLOSE frame before entering the draining state, using a +CONNECTION_CLOSE frame and a NO_ERROR code if appropriate. An endpoint MUST NOT +send further packets, which could result in a constant exchange of +CONNECTION_CLOSE frames until the closing period on either peer ended. I think actually it causes one of the endpoints to remain in closing instead of draining, but the spec says "The draining period SHOULD end when the closing period would have ended," so I think the time is the same whether you transition or not. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1900#discussion_r229109004
- [quicwg/base-drafts] One close frames (#1900) Martin Thomson
- Re: [quicwg/base-drafts] One close frames (#1900) Kazuho Oku
- Re: [quicwg/base-drafts] One close frames (#1900) MikkelFJ
- Re: [quicwg/base-drafts] One close frames (#1900) ianswett
- Re: [quicwg/base-drafts] One close frames (#1900) ianswett
- Re: [quicwg/base-drafts] One close frames (#1900) MikkelFJ
- Re: [quicwg/base-drafts] One close frames (#1900) ianswett
- Re: [quicwg/base-drafts] One close frames (#1900) ianswett
- Re: [quicwg/base-drafts] One close frames (#1900) Marten Seemann
- Re: [quicwg/base-drafts] One close frames (#1900) Lucas Pardue
- Re: [quicwg/base-drafts] One close frames (#1900) Martin Thomson
- Re: [quicwg/base-drafts] One close frames (#1900) Martin Thomson
- Re: [quicwg/base-drafts] One close frames (#1900) Lucas Pardue
- Re: [quicwg/base-drafts] One close frames (#1900) Nick Banks
- Re: [quicwg/base-drafts] One close frames (#1900) Martin Thomson
- Re: [quicwg/base-drafts] One close frames (#1900) Mike Bishop
- Re: [quicwg/base-drafts] One close frames (#1900) Mike Bishop
- Re: [quicwg/base-drafts] One close frames (#1900) MikkelFJ
- Re: [quicwg/base-drafts] One close frames (#1900) Mike Bishop
- Re: [quicwg/base-drafts] One close frames (#1900) Martin Thomson
- Re: [quicwg/base-drafts] One close frames (#1900) Martin Thomson
- Re: [quicwg/base-drafts] One close frames (#1900) janaiyengar
- Re: [quicwg/base-drafts] One close frames (#1900) Martin Thomson
- Re: [quicwg/base-drafts] One close frames (#1900) Martin Thomson
- Re: [quicwg/base-drafts] One close frames (#1900) Martin Thomson
- Re: [quicwg/base-drafts] One close frames (#1900) Martin Thomson
- Re: [quicwg/base-drafts] One close frames (#1900) Martin Thomson
- Re: [quicwg/base-drafts] One close frames (#1900) Martin Thomson
- Re: [quicwg/base-drafts] One close frames (#1900) ianswett
- Re: [quicwg/base-drafts] One close frames (#1900) Martin Thomson
- Re: [quicwg/base-drafts] One close frames (#1900) Martin Thomson