Re: [quicwg/base-drafts] Remove 1 RTT delayed ack requirement (#3055)
Martin Thomson <notifications@github.com> Tue, 24 September 2019 22:34 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A9F7E120845 for <quic-issues@ietfa.amsl.com>; Tue, 24 Sep 2019 15:34:35 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EH8zMZsGk0YB for <quic-issues@ietfa.amsl.com>; Tue, 24 Sep 2019 15:34:33 -0700 (PDT)
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 429161200F7 for <quic-issues@ietf.org>; Tue, 24 Sep 2019 15:34:33 -0700 (PDT)
Date: Tue, 24 Sep 2019 15:34:32 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1569364472; bh=AvOh6y25G+kbPJCFv7kQMdhWB7/vLge4UyN/DvgNjZ0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=hN8e7HRCQv7aVDAPXPdB2BFKWlOlVhVCUQj15uYK6L/SE1EiaDysvtX2dYdsQugr0 uTZmd5o6rhmBfRWKQMQd8bPg29ytK8M+k2Xe0gbPgLGoHkJ3SugwyyYtDRxk1k9o46 Quce0dHS812OcUSbHTvGohsVCrtaWNmLncw3cUcw=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK5WVMTRKIMYPAAROF53S67GREVBNHHB3FVVWY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3055/review/292744200@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3055@github.com>
References: <quicwg/base-drafts/pull/3055@github.com>
Subject: Re: [quicwg/base-drafts] Remove 1 RTT delayed ack requirement (#3055)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d8a99f842307_46cc3fbc0cacd96c78713"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/mKj7rL4_UZlAwxuIZprOmDqvd58>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Sep 2019 22:34:36 -0000
martinthomson approved this pull request.
> @@ -3009,11 +3009,16 @@ guidance offered below seeks to strike this balance.
An ACK frame SHOULD be generated for at least every second ack-eliciting packet.
This recommendation is in keeping with standard practice for TCP {{?RFC5681}}.
-A receiver's delayed acknowledgment timer SHOULD NOT exceed the current RTT
-estimate or the value it indicates in the `max_ack_delay` transport parameter.
-This ensures an acknowledgment is sent at least once per RTT when packets
-needing acknowledgement are received. The sender can use the receiver's
-`max_ack_delay` value in determining timeouts for timer-based retransmission.
+An endpoint MUST NOT excessively delay acknowledgements of ack-eliciting
+packets. An endpoint commits to a maximum delay using the max_ack_delay
+transport parameter; see {{transport-parameter-definitions}}. max_ack_delay
+declares an explicit contract: an endpoint promises to never delay
+acknowledgments of an ack-eliciting packet by more than the indicated value. If
+it does, any excess accrues to the RTT estimate and could result in delayed
+retransmissions from the peer. For Initial and Handshake packets, a
+max_ack_delay of 0 is used. The sender uses the receiver's `max_ack_delay`
+value in determining timeouts for timer-based retransmission, as detailed
+in section 5.2.1 of {{QUIC-RECOVERY}}.
```suggestion
in Section 5.2.1 of {{QUIC-RECOVERY}}.
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3055#pullrequestreview-292744200
- [quicwg/base-drafts] Remove 1 RTT delayed ack req… ianswett
- Re: [quicwg/base-drafts] Remove 1 RTT delayed ack… ianswett
- Re: [quicwg/base-drafts] Remove 1 RTT delayed ack… Nick Banks
- Re: [quicwg/base-drafts] Remove 1 RTT delayed ack… ianswett
- Re: [quicwg/base-drafts] Remove 1 RTT delayed ack… Martin Thomson
- Re: [quicwg/base-drafts] Remove 1 RTT delayed ack… ianswett
- Re: [quicwg/base-drafts] Remove 1 RTT delayed ack… Martin Thomson
- Re: [quicwg/base-drafts] Remove 1 RTT delayed ack… mirjak