Re: [quicwg/base-drafts] Why are error codes not a varint? (#1940)

Kazuho Oku <notifications@github.com> Wed, 31 October 2018 07:52 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id ABDCB128C65 for <quic-issues@ietfa.amsl.com>; Wed, 31 Oct 2018 00:52:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id A14WUuvR0cI1 for <quic-issues@ietfa.amsl.com>; Wed, 31 Oct 2018 00:52:42 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A6A29127B92 for <quic-issues@ietf.org>; Wed, 31 Oct 2018 00:52:42 -0700 (PDT)
Date: Wed, 31 Oct 2018 00:52:40 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1540972360; bh=WRYclVITZJW+nZVoHkehwY5Zp7csnxuXml5yRrtGSGs=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=yL+ueBrl4JqxPO8NmgNi5WKFGqpYOY1BFCQYeBYDDeWe7tl4WqBsKXUiP+j3xKnv6 a/ZdWzVIBj608+3pKc8HoQQKve/E8O1vdZi396qG6S4bOQKfghrINgQBtt8GwjE790 KR03/k0Ae889ZFDJvGn5GYVFs1VYwxYumzdxWA6o=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab311f72a91bf68a7e97e44acbdb97bb6357b5ce0992cf0000000117f1214892a169ce16660d11@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1940/434592735@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1940@github.com>
References: <quicwg/base-drafts/issues/1940@github.com>
Subject: Re: [quicwg/base-drafts] Why are error codes not a varint? (#1940)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bd95f48e5a68_7b883ff841cd45b492851c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/mWtKMSkI-pLz95xUS_9b0nzTzq0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Oct 2018 07:52:45 -0000

I think there are pros and cons in using a varint.

The pro is that we'd have a chance to save an octet as have been pointed out.

The cons that I see are:
* It would not give us any benefit when the application protocol defines error codes in groups (e.g., upper 8 bits indicate the category of the error and lower 8 bits indicate the details). To generalize, I am not sure if we can anticipate that the number space will be used from 0 and onwards unlike other variables that we send.
* It is a bit strange to state that an error code is a *62*-bit variable rather than a type that uses a multiple of 8-bits.

I do not have a strong opinion but considering the cons sticking with `uint16_t` is not too strange to me.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1940#issuecomment-434592735