IETF Logo Mail Archive

Re: [quicwg/base-drafts] Fix Recovery Pseudocode (#2907)

martinduke <notifications@github.com> Sat, 20 July 2019 22:05 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6B0F01201E0 for <quic-issues@ietfa.amsl.com>; Sat, 20 Jul 2019 15:05:24 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.597
X-Spam-Level:
X-Spam-Status: No, score=-6.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8mvUbYjTHbGw for <quic-issues@ietfa.amsl.com>; Sat, 20 Jul 2019 15:05:22 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 93F8F120112 for <quic-issues@ietf.org>; Sat, 20 Jul 2019 15:05:22 -0700 (PDT)
Date: Sat, 20 Jul 2019 15:05:21 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1563660321; bh=OOGvGurdRc5detAcIHTP76Tl9XMGyDNrd5pJXrZkHko=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=y367qVzQhQ54nFbQegMpXKTZZYaa99KCL0f/UhkMbO/1x1oP3wNraTkQi1/P/QAd4 Q8axYlKIyDcFoh6sRB/pyFlQ+2bWCMU+BqnfsSSMWnK37Rpf8ro+79I8XZoUPi/ws/ ay7R+Z2MjY5Y6Hbc9eizVqDMM/nl4/1ObyNXNdsw=
From: martinduke <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK53V3SBUZQMFBJUGUV3IDBKDEVBNHHBX66EHQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2907/review/264513006@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2907@github.com>
References: <quicwg/base-drafts/pull/2907@github.com>
Subject: Re: [quicwg/base-drafts] Fix Recovery Pseudocode (#2907)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d33902137e25_2fee3fbe25ecd95c5172c4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinduke
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/mcHXuoh1vgVa0IbBhgiT4x-GsfQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 20 Jul 2019 22:05:24 -0000

martinduke commented on this pull request.



> @@ -1188,9 +1188,10 @@ SetLossDetectionTimer():
     return
 
   // Don't arm timer if there are no ack-eliciting packets
-  // in flight and the handshake is complete.
-  if (endpoint is client with 1-RTT keys &&
-      no ack-eliciting packets in flight):
+  // in flight and the endpoint is a server or has
+  // completed the handshake.
+  if (no ack-eliciting packets in flight &&
+      (endpoint is server or has 1-RTT keys)):

Sorry, just add "has received HS ack" and we're good. There's a case where the server flight doesn't fit in a cwnd and the extra text may save us a crypto timeout.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2907#discussion_r305594861

v2.23.0 | Report a Bug | By Email