Return-Path: X-Original-To: quic-issues@ietfa.amsl.com Delivered-To: quic-issues@ietfa.amsl.com Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3AA723A22C4 for ; Mon, 13 Apr 2020 18:32:47 -0700 (PDT) X-Virus-Scanned: amavisd-new at amsl.com X-Spam-Flag: NO X-Spam-Score: -3.267 X-Spam-Level: X-Spam-Status: No, score=-3.267 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.168, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 50TuTp89bMtj for ; Mon, 13 Apr 2020 18:32:45 -0700 (PDT) Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8FA113A22C2 for ; Mon, 13 Apr 2020 18:32:45 -0700 (PDT) Received: from github-lowworker-bb778fb.ash1-iad.github.net (github-lowworker-bb778fb.ash1-iad.github.net [10.56.102.56]) by smtp.github.com (Postfix) with ESMTP id A4126520357 for ; Mon, 13 Apr 2020 18:32:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1586827964; bh=ppO0mQ7KLrxiH48emjp8TCIBrv3VYNWLT+qIXBKCLhA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=wGKbjJg8fjlWJeaUOEp5tOtmGRk9Oi1PS9nDZH3Cn25wsNb7wjpjCqTw41qjmUdkA Fgxk1fTwReiMPSfj3zJhsjrUWKRwq/tkbchFmn3lOVgEPFPY57lbxVbW59DxjnpoiZ gMJ38j7qORX5ON1LcxHiLOKjg3owzYma0VpgZw5I= Date: Mon, 13 Apr 2020 18:32:44 -0700 From: Martin Thomson Reply-To: quicwg/base-drafts To: quicwg/base-drafts Cc: Subscribed Message-ID: In-Reply-To: References: Subject: Re: [quicwg/base-drafts] [qpack] Overhaul the pseudocode (#3577) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5e9512bc94814_68f13fbdd22cd95c1710b2"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: martinthomson X-GitHub-Recipient: quic-issues X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: quic-issues@ietf.org Archived-At: X-BeenThere: quic-issues@ietf.org X-Mailman-Version: 2.1.29 List-Id: Notification list for GitHub issues related to the QUIC WG List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2020 01:32:47 -0000 ----==_mimepart_5e9512bc94814_68f13fbdd22cd95c1710b2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit @martinthomson commented on this pull request. I couldn't see any problems, but I have some suggestions. Thanks for doing the cleanup. > for header in headers: - staticIdx = staticTable.getIndex(header) - if staticIdx: - encodeIndexReference(streamBuffer, staticIdx) + staticIndex = staticTable.getIndex(header) ```suggestion staticIndex = staticTable.findIndex(header) ``` This is a search, right? > continue - dynamicIdx = dynamicTable.getIndex(header) - if !dynamicIdx: + dynamicIndex = dynamicTable.getIndex(header) ```suggestion dynamicIndex = dynamicTable.findIndex(header) ``` > # No matching entry. Either insert+index or encode literal - nameIdx = getNameIndex(header) + + # getNameIndex attempts to find an index for this header's name. + # If one exists, it returns the name's (absolute) index and a + # boolean indicating which table has the name. If the name + # can't be found, nameIndex is None + nameIndex, isStaticName = getNameIndex(header.name) This is a little strange, as you are relying on functions on the tables to find the full entry, but you jump to a different approach for looking up the name. I realize that two lookups are worse than one, but it's an odd stylistic jump, that's all. ```python # An alternative might be to do the name lookup like this: staticNameIndex = staticTable.findName(header.name) if staticNameIndex is None: dynamicNameIndex = dynamicTable.findName(header.name) if header.canIndex() and dynamicTable.canAdd(header): encodeInsert(encoderBuffer, staticNameIndex, dynamicNameIndex, header) dynamicIndex = dynamicTable.add(header) # For a bonus, continuing from the above, forget about the # newly inserted dynamic table entry if we are at the limit of blocked streams. if numBlockedStreams >= maxBlockedStreams: dynamicIndex = None else: addedBlockingEntry = True # Later, you can increase numBlockedStreams, but you only do that once. ``` > dynamicTable.add(header) - dynamicIdx = dynamicTable.baseIndex + dynamicIndex = dynamicTable.getInsertCount() I can't suggest here, but I think that you just want this: ```python dynamicIndex = dynamicTable.add(header) ``` Otherwise you are breaking encapsulation in a small way: relying on the insert count for getting the index of the thing you just added. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3577#pullrequestreview-392540915 ----==_mimepart_5e9512bc94814_68f13fbdd22cd95c1710b2 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

=0D

@martinthomson commented on this pull request.

=0D =0D

I couldn't see any problems, but I have some suggestions.

=0D

Thanks for doing the cleanup.

=0D =0D

In draft-ietf-quic-qpack.md:

=0D 
>  for header in headers:=0D
-  staticIdx =3D staticTable.getIndex(header)=0D
-  if staticIdx:=0D
-    encodeIndexReference(streamBuffer, staticIdx)=0D
+  staticIndex =3D staticTable.getIndex(header)=0D
=0D =E2=AC=87=EF=B8=8F Suggested change=0D 
-  staticIndex =3D staticTable.getIndex(header=
)=0D
+  staticIndex =3D staticTable.findIndex(header)=0D
=0D =0D

This is a search, right?

=0D =0D
=0D =0D

In draft-ietf-quic-qpack.md:

=0D 
>      continue=0D
 =0D
-  dynamicIdx =3D dynamicTable.getIndex(header)=0D
-  if !dynamicIdx:=0D
+  dynamicIndex =3D dynamicTable.getIndex(header)=0D
=0D =E2=AC=87=EF=B8=8F Suggested change=0D 
-  dynamicIndex =3D dynamicTable.getIndex(head=
er)=0D
+  dynamicIndex =3D dynamicTable.findIndex(header)=0D
=0D =0D =0D
=0D =0D

In draft-ietf-quic-qpack.md:

=0D 
>      # No matching entry.  Either insert+i=
ndex or encode literal=0D
-    nameIdx =3D getNameIndex(header)=0D
+=0D
+    # getNameIndex attempts to find an index for this header's name.=
=0D
+    # If one exists, it returns the name's (absolute) index and a=0D=

+    # boolean indicating which table has the name.  If the name=0D
+    # can't be found, nameIndex is None=0D
+    nameIndex, isStaticName =3D getNameIndex(header.name)=0D
=0D

This is a little strange, as you are relying on functions on the table= s to find the full entry, but you jump to a different approach for lookin= g up the name. I realize that two lookups are worse than one, but it's a= n odd stylistic jump, that's all.

=0D 
# An alternative might be to do the name lo=
okup like this:=0D
staticNameIndex =3D staticTable.findName(head=
er.name)=0D
if staticNameIndex is None:=0D
    dynamicNameIndex =3D dynamicTable.findNam=
e(header.name)=0D
if header.canIndex() and=
 dynamicTable.canAdd(header):=0D
    encodeInsert(encoderBuffer, staticNameIndex, dynamicNameIndex, header=
)=0D
    dynamicIndex =3D dynamicTable.add(header)=
=0D
=0D
    # For a bonus, conti=
nuing from the above, forget about the=0D
    # newly inserted dyn=
amic table entry if we are at the limit of blocked streams.=0D
    if numBlockedStreams >=3D maxBlockedStreams:=0D
        dynamicIndex =3D None=0D
    else:=0D
        addedBlockingEntry =3D True=0D
        # Later, you can=
 increase numBlockedStreams, but you only do that once.
=0D =0D
=0D =0D

In draft-ietf-quic-qpack.md:

=0D 
>        dynamicTable.add(header)=0D
-      dynamicIdx =3D dynamicTable.baseIndex=0D
+      dynamicIndex =3D dynamicTable.getInsertCount()=0D
=0D

I can't suggest here, but I think that you just want this:

=0D 
        dynamicInde=
x =3D dynamicTable.add(header)
=0D=

Otherwise you are breaking encapsulation in a small way: relying on th= e insert count for getting the index of the thing you just added.

=0D =0D

&m= dash;
You are receiving this because you are subscribed to this thre= ad.
Reply to this email directly, view it on GitHub, or unsubscribe.3D""

=0D = ----==_mimepart_5e9512bc94814_68f13fbdd22cd95c1710b2--