Re: [quicwg/base-drafts] Fix Recovery Pseudocode (#2907)

[ianswett <[e-mail]>]

ianswett commented on this pull request.



> @@ -581,13 +581,13 @@ data.  If no data can be sent, then the PTO alarm MUST NOT be armed until
 data has been received from the client.
 
 Because the server could be blocked until more packets are received, the client
-MUST ensure that the retransmission timer is set if the client does not yet
-have 1-RTT keys.  If the probe timer expires before the client has 1-RTT keys,
-it is possible that the client may not have any crypto data to retransmit.
-However, the client MUST send a new packet, containing only PADDING frames if
-necessary, to allow the server to continue sending data. If Handshake keys
-are available to the client, it MUST send a Handshake packet, and otherwise
-it MUST send an Initial packet in a UDP datagram of at least 1200 bytes.
+MUST ensure that the retransmission timer is set if the client has not received
+an ACK in a Handshake packet or does not yet have 1-RTT keys.  If the probe

I think Martin's right, this should be 'and', since if the client has 1-RTT keys and has nothing to send at lower encryption levels, 

But now that I write that out, would it be better to say "received an ACK in a Handshake or 1-RTT packet."?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2907#discussion_r317152240