Re: [quicwg/base-drafts] A pacing algorithm (#3630)

Martin Thomson <notifications@github.com> Tue, 12 May 2020 23:15 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BBE023A0C6A for <quic-issues@ietfa.amsl.com>; Tue, 12 May 2020 16:15:20 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.273
X-Spam-Level:
X-Spam-Status: No, score=-3.273 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.173, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VnDpJNSmdjUl for <quic-issues@ietfa.amsl.com>; Tue, 12 May 2020 16:15:19 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 42D3F3A0C61 for <quic-issues@ietf.org>; Tue, 12 May 2020 16:15:19 -0700 (PDT)
Received: from github-lowworker-e8b54ca.ac4-iad.github.net (github-lowworker-e8b54ca.ac4-iad.github.net [10.52.23.39]) by smtp.github.com (Postfix) with ESMTP id 99F892C1C49 for <quic-issues@ietf.org>; Tue, 12 May 2020 16:15:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1589325318; bh=+kyUtvAhT+AG7pBNipilAhdsNhdXUQ5T/T1Z7FVT5pQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=VVMlCjXc0oBnYvZbglqNlZnjlz8I+yI1ImYsfqlpp/P0baogRYbdoh7A52C5jgAI/ 8t8LgCAK4DT2B0N+Ql8LrmyxdpNnw7+tO17eHKYGZgmKvy8pthOUXF3a1ZHqzRITcc em2YeZEQIIvk2J23ufe4Mc1ErTeLZ3iYzLZSqs2I=
Date: Tue, 12 May 2020 16:15:18 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7MCICOPRO53GU5WSF4Y4HQNEVBNHHCJCUB5E@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3630/review/410481829@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3630@github.com>
References: <quicwg/base-drafts/pull/3630@github.com>
Subject: Re: [quicwg/base-drafts] A pacing algorithm (#3630)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ebb2e068ace2_3b973fa4902cd96c1313cd"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/mhfU69DLRiC0Zpc-XJDHEgZ5iGg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 12 May 2020 23:15:21 -0000

@martinthomson commented on this pull request.



> +following relation for the total number of bytes sent over any interval:
+
+~~~
+sent@t[n] - sent@t[m]
+    <= N * congestion_window * (t[m] - t[n]) / smoothed_rtt
+       + min(10 * max_datagram_size,
+             max(2 * max_datagram_size, 14720))
+~~~
+
+The inclusion of the factor, `N`, that increases the rate of sending is to
+anticipate increases in sending rate as the congestion window expands. Sending
+at a higher rate also avoids having scheduling delays reduce the send rate
+below that allowed by the congestion controller. A value of 2 ensures that
+pacing is unlikely to limit what is sent any more than the congestion
+controller.
+

```suggestion

An endpoint that does not burst packets and has even spacing between packets
might send packets spaced at intervals of:

~~~
inter-packet time = smoothed_rtt * packet_size / congestion_window / N
~~~
```

> +The inclusion of the factor, `N`, that increases the rate of sending is to
+anticipate increases in sending rate as the congestion window expands. Sending
+at a higher rate also avoids having scheduling delays reduce the send rate
+below that allowed by the congestion controller. A value of 2 ensures that
+pacing is unlikely to limit what is sent any more than the congestion
+controller.

```suggestion
The inclusion of the factor, `N`, with a value of at least 1 increases the rate
of sending. The value of `N` might be increased to avoid having scheduling
delays reduce the send rate below that allowed by the congestion controller.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3630#pullrequestreview-410481829