Re: [quicwg/base-drafts] Merge ACK and ACK_ECN (#1801)

[Martin Thomson <[e-mail]>]

martinthomson commented on this pull request.

I might have done a more thorough renumber, but this is a nice minimal change.  We can kick around the renumbering thing later.

>  
 Gap and ACK Block fields use a relative integer encoding for efficiency.  Though
 each encoded value is positive, the values are subtracted, so that each ACK
 Block describes progressively lower-numbered packets.  As long as contiguous
 ranges of packets are small, the variable-length integer encoding ensures that
 each range can be expressed in a small number of octets.
 
+The ACK frame uses the least significant bit(type=0x1b) to indicate ECN feedback

"bit (that is, type 0x1b)"

> @@ -3374,9 +3373,11 @@ Application Error Code:
 
 ## ACK Frame {#frame-ack}
 
-Receivers send ACK frames (type=0x0d) to inform senders which packets they have
-received and processed. The ACK frame contains any number of ACK blocks.
-ACK blocks are ranges of acknowledged packets.
+Receivers send ACK frames (types=0x1a - 0x1b) to inform senders of packets they

(types 0x1a and 0x1b)

> @@ -3374,9 +3373,11 @@ Application Error Code:
 
 ## ACK Frame {#frame-ack}
 
-Receivers send ACK frames (type=0x0d) to inform senders which packets they have
-received and processed. The ACK frame contains any number of ACK blocks.
-ACK blocks are ranges of acknowledged packets.
+Receivers send ACK frames (types=0x1a - 0x1b) to inform senders of packets they
+have received and processed. The ACK frame contains one or more ACK blocks. ACK

should we be capitalizing the B in ACK Blocks?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1801#pullrequestreview-159060395