Re: [quicwg/base-drafts] Move stream type into frame type (#1431)

Mike Bishop <notifications@github.com> Tue, 12 June 2018 18:15 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C9A07130FA2 for <quic-issues@ietfa.amsl.com>; Tue, 12 Jun 2018 11:15:37 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.009
X-Spam-Level:
X-Spam-Status: No, score=-3.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RZtQStixPoRm for <quic-issues@ietfa.amsl.com>; Tue, 12 Jun 2018 11:15:35 -0700 (PDT)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9DB58130E7B for <quic-issues@ietf.org>; Tue, 12 Jun 2018 11:15:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=mnqFg7KPfTzacQ4s400EWPu7NZQ=; b=RpRhh6nHDG4PY4zi kuFG8JRyvrSvwwpbfP0pIB8r2hAU5Rfs0zp/qqp62U8jh8dwac+KXhqND02mv9+w +YzQdXWtWWmqep96Q7izfaKV06F90gG6/8KLyZ6G3JGFVc4+nBDOb+z2m52wpcj3 1tQayVtdyTEMss3wG0QwXW3//Gk=
Received: by filter0826p1las1.sendgrid.net with SMTP id filter0826p1las1-12651-5B200DC5-15 2018-06-12 18:15:33.465409865 +0000 UTC
Received: from github-lowworker9-cp1-prd.iad.github.net (unknown [192.30.252.47]) by ismtpd0002p1iad1.sendgrid.net (SG) with ESMTP id jWP7N6sKRRaeSKwnL9k0Uw for <quic-issues@ietf.org>; Tue, 12 Jun 2018 18:15:33.434 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker9-cp1-prd.iad.github.net (Postfix) with ESMTP id 6848DA0265 for <quic-issues@ietf.org>; Tue, 12 Jun 2018 11:15:33 -0700 (PDT)
Date: Tue, 12 Jun 2018 18:15:33 +0000
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab77cf15b33d25d7df3406a0f450b51cf50da1031592cf000000011737cfc592a169ce13b4e51c@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1431/c396684983@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1431@github.com>
References: <quicwg/base-drafts/pull/1431@github.com>
Subject: Re: [quicwg/base-drafts] Move stream type into frame type (#1431)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b200dc5667bd_79093fb6837d0f7c21178f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3ARmRCLoTfw52YbL9xARAKgbrrRv2VNfbKlu EcEptjF8+qV+kNEyrgTb7Zd8Qtm3+HxiRxaBjTgpd41NgQbtN/X9/0gC4siD+QU9pafZmhZmYL4/UO SBpqvOlYVMISQPvfjglxV0iTPAK+CHZBomaHLZh9sex+8GFO6v/Ul8BQ/PLlvJD+w0gJCq1s1eyrK2 k=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/mmqJyT0lWmKjj1elx22401ytYXE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Jun 2018 18:15:38 -0000

@martinthomson, I'm curious about the source of the performance hit.  Was it simply from using a non-byte-aligned varint?  If so, that seems separate from this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1431#issuecomment-396684983