[quicwg/version-negotiation] 00237b: Conversion cannot fail

David Schinazi <noreply@github.com> Mon, 07 March 2022 23:50 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C93473A11ED for <quic-issues@ietfa.amsl.com>; Mon, 7 Mar 2022 15:50:42 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.111
X-Spam-Level:
X-Spam-Status: No, score=-2.111 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8UDXWDKJLu-F for <quic-issues@ietfa.amsl.com>; Mon, 7 Mar 2022 15:50:37 -0800 (PST)
Received: from smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7867D3A136B for <quic-issues@ietf.org>; Mon, 7 Mar 2022 15:50:32 -0800 (PST)
Received: from github.com (hubbernetes-node-0a4508f.ac4-iad.github.net [10.52.125.64]) by smtp.github.com (Postfix) with ESMTPA id 21B35560083 for <quic-issues@ietf.org>; Mon, 7 Mar 2022 15:50:31 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1646697031; bh=Q+XoBKW1vcqsder4MgN30GFp1oBl2Er5lhqigCw9UK8=; h=Date:From:To:Subject:From; b=NQE8TfSMmMD8RtuQpW4vH/Pb6WkPK0bmd1wWuoRl8LROvmw5vhw/FqyjTsH8HdZdZ YKsOeLqJSCMl83rOXWJet6I8+p3KXnW3jZir/kkK3LHsGwidUfF7Fd4XtypLPTLytz kCLJbh/VCZRAhP7XyHClJxAtZrZpznmmqANUybI8=
Date: Mon, 07 Mar 2022 15:50:31 -0800
From: David Schinazi <noreply@github.com>
To: quic-issues@ietf.org
Message-ID: <quicwg/version-negotiation/push/refs/heads/v1_is_special/c98a07-0f1748@github.com>
Subject: [quicwg/version-negotiation] 00237b: Conversion cannot fail
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-Auto-Response-Suppress: All
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/mnrM59clms6fd_XOpcl-U0gr2bM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Mar 2022 23:50:43 -0000

  Branch: refs/heads/v1_is_special
  Home:   https://github.com/quicwg/version-negotiation
  Commit: 00237b279c13dff76384f3937504141fc7d25a26
      https://github.com/quicwg/version-negotiation/commit/00237b279c13dff76384f3937504141fc7d25a26
  Author: David Schinazi <dschinazi.ietf@gmail.com>
  Date:   2021-11-19 (Fri, 19 Nov 2021)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  Conversion cannot fail


  Commit: fa9bf9f98efd2b12a24a1118a382a94cad047154
      https://github.com/quicwg/version-negotiation/commit/fa9bf9f98efd2b12a24a1118a382a94cad047154
  Author: David Schinazi <dschinazi.ietf@gmail.com>
  Date:   2021-11-19 (Fri, 19 Nov 2021)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  Clarify that clients only list useful compatible versions


  Commit: c02bbc48cd61487860d9639ce1c01f51aff3995b
      https://github.com/quicwg/version-negotiation/commit/c02bbc48cd61487860d9639ce1c01f51aff3995b
  Author: David Schinazi <dschinazi.ietf@gmail.com>
  Date:   2021-11-19 (Fri, 19 Nov 2021)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  Clarify that Version Information is invariant but its encoding is not


  Commit: 1734559907a1b6ae958c43c44f935eb9272dad76
      https://github.com/quicwg/version-negotiation/commit/1734559907a1b6ae958c43c44f935eb9272dad76
  Author: David Schinazi <dschinazi.ietf@gmail.com>
  Date:   2021-11-19 (Fri, 19 Nov 2021)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  Soften requirement on address stability


  Commit: 310a9e5ab229f074daada6367aa98f04d773fca9
      https://github.com/quicwg/version-negotiation/commit/310a9e5ab229f074daada6367aa98f04d773fca9
  Author: David Schinazi <dschinazi.ietf@gmail.com>
  Date:   2021-11-30 (Tue, 30 Nov 2021)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  Clarify other versions empty


  Commit: b6bdcee9db29a9a94ee6787895309556c681d375
      https://github.com/quicwg/version-negotiation/commit/b6bdcee9db29a9a94ee6787895309556c681d375
  Author: David Schinazi <DavidSchinazi@users.noreply.github.com>
  Date:   2021-12-02 (Thu, 02 Dec 2021)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  Merge pull request #71 from quicwg/may_be_empty

Clarify other versions empty


  Commit: 5ba222e5e4379a0332cd3d9729a5782cc0a6b4b9
      https://github.com/quicwg/version-negotiation/commit/5ba222e5e4379a0332cd3d9729a5782cc0a6b4b9
  Author: David Schinazi <DavidSchinazi@users.noreply.github.com>
  Date:   2021-12-02 (Thu, 02 Dec 2021)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  Merge pull request #64 from quicwg/stable_address

Soften requirement on address stability


  Commit: b5efb95913f62f3157902f7be24d0e9b8c90fbf5
      https://github.com/quicwg/version-negotiation/commit/b5efb95913f62f3157902f7be24d0e9b8c90fbf5
  Author: David Schinazi <DavidSchinazi@users.noreply.github.com>
  Date:   2021-12-02 (Thu, 02 Dec 2021)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  Merge pull request #63 from quicwg/invariant

Clarify that Version Information is invariant but its encoding is not


  Commit: 608ab29e81878d10741bf8de7779d86608ef88a3
      https://github.com/quicwg/version-negotiation/commit/608ab29e81878d10741bf8de7779d86608ef88a3
  Author: David Schinazi <DavidSchinazi@users.noreply.github.com>
  Date:   2021-12-02 (Thu, 02 Dec 2021)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  Merge pull request #61 from quicwg/application_reqs

Clarify that clients only list useful compatible versions


  Commit: c160cf3eb790a0295c2d95106b382f7facb2e1e2
      https://github.com/quicwg/version-negotiation/commit/c160cf3eb790a0295c2d95106b382f7facb2e1e2
  Author: David Schinazi <DavidSchinazi@users.noreply.github.com>
  Date:   2021-12-02 (Thu, 02 Dec 2021)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  Merge pull request #60 from quicwg/convert_fail

Conversion cannot fail


  Commit: fac23376fb9f6ecd7192cfebf3c32506ea51e1c8
      https://github.com/quicwg/version-negotiation/commit/fac23376fb9f6ecd7192cfebf3c32506ea51e1c8
  Author: David Schinazi <dschinazi.ietf@gmail.com>
  Date:   2021-12-02 (Thu, 02 Dec 2021)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  Clarify that VN validation fails if server other versions are empty


  Commit: 074b51ca456b8dadc5bf4f37956f830cd5e6cef0
      https://github.com/quicwg/version-negotiation/commit/074b51ca456b8dadc5bf4f37956f830cd5e6cef0
  Author: David Schinazi <DavidSchinazi@users.noreply.github.com>
  Date:   2022-03-04 (Fri, 04 Mar 2022)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  Merge pull request #75 from quicwg/clarify_empty_server_other_validation

Clarify that VN validation fails if server other versions are empty


  Commit: 6379bc7c202aead768d62d64ce31c78f9511d156
      https://github.com/quicwg/version-negotiation/commit/6379bc7c202aead768d62d64ce31c78f9511d156
  Author: martinduke <martin.h.duke@gmail.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  much much shorter


  Commit: c5ab54182e88b853ba3151a9cb7be29e1a845e3f
      https://github.com/quicwg/version-negotiation/commit/c5ab54182e88b853ba3151a9cb7be29e1a845e3f
  Author: martinduke <martin.h.duke@gmail.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  David's suggestion to fix this


  Commit: 06c464a6fefb341de2af14fc163e4cb27bcc7cee
      https://github.com/quicwg/version-negotiation/commit/06c464a6fefb341de2af14fc163e4cb27bcc7cee
  Author: ekr <ekr@rtfm.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  Merge pull request #84 from martinduke/compatible-def

Consider 0RTT in definition of compatible.


  Commit: 2156c8e8b08612c2872a8b9b2745bef521f7ec04
      https://github.com/quicwg/version-negotiation/commit/2156c8e8b08612c2872a8b9b2745bef521f7ec04
  Author: martinduke <martin.h.duke@gmail.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  Update draft-ietf-quic-version-negotiation.md

Co-authored-by: David Schinazi <DavidSchinazi@users.noreply.github.com>


  Commit: 747aca0c8aa59a76ccdfdfaadecf064d7e81c66c
      https://github.com/quicwg/version-negotiation/commit/747aca0c8aa59a76ccdfdfaadecf064d7e81c66c
  Author: David Schinazi <DavidSchinazi@users.noreply.github.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  Merge pull request #83 from martinduke/smaller-min-support

min support, but much much shorter


  Commit: cd8274e51b6ac1be93f9f4bc12e6e6aa9665732a
      https://github.com/quicwg/version-negotiation/commit/cd8274e51b6ac1be93f9f4bc12e6e6aa9665732a
  Author: martinduke <martin.h.duke@gmail.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  clarify handling of multiple ALPNs


  Commit: fafe7bdbc94957e65f04b323906f9e232c6374fb
      https://github.com/quicwg/version-negotiation/commit/fafe7bdbc94957e65f04b323906f9e232c6374fb
  Author: David Schinazi <DavidSchinazi@users.noreply.github.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  Merge pull request #85 from martinduke/single-alpn

clarify handling of multiple ALPNs


  Commit: 661a272ac4a2ed875a29a7b3913f5e286026b861
      https://github.com/quicwg/version-negotiation/commit/661a272ac4a2ed875a29a7b3913f5e286026b861
  Author: David Schinazi <dschinazi.ietf@gmail.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  fix ref


  Commit: 57b0b1eeaaf54ed3b1c7814db1699d1546f4de7f
      https://github.com/quicwg/version-negotiation/commit/57b0b1eeaaf54ed3b1c7814db1699d1546f4de7f
  Author: David Schinazi <dschinazi.ietf@gmail.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  missing word


  Commit: 8283766227b45e1d07df1ef08eff57db8a962814
      https://github.com/quicwg/version-negotiation/commit/8283766227b45e1d07df1ef08eff57db8a962814
  Author: martinduke <martin.h.duke@gmail.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  handle TP with version = 0


  Commit: 9305f32513f318ac585548a4ecd87554d05f6304
      https://github.com/quicwg/version-negotiation/commit/9305f32513f318ac585548a4ecd87554d05f6304
  Author: David Schinazi <dschinazi.ietf@gmail.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  Clarify meaning of the negotiated version on the client


  Commit: b2e5ebefd313b45ae2575f6cf17e8344b8a36ae5
      https://github.com/quicwg/version-negotiation/commit/b2e5ebefd313b45ae2575f6cf17e8344b8a36ae5
  Author: David Schinazi <dschinazi.ietf@gmail.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  fix downgrade


  Commit: 84f9a97b86be75682bb43aadff90a783a1cd9e7a
      https://github.com/quicwg/version-negotiation/commit/84f9a97b86be75682bb43aadff90a783a1cd9e7a
  Author: David Schinazi <DavidSchinazi@users.noreply.github.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  Merge pull request #87 from quicwg/clarify_negotiated_version

Clarify negotiated version


  Commit: ca1f28ade02a13f2742c46900d6bda8ff1e8d498
      https://github.com/quicwg/version-negotiation/commit/ca1f28ade02a13f2742c46900d6bda8ff1e8d498
  Author: martinduke <martin.h.duke@gmail.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  David's comment


  Commit: c7e1c384c047530fb1a6968cf97833b5d428ad0a
      https://github.com/quicwg/version-negotiation/commit/c7e1c384c047530fb1a6968cf97833b5d428ad0a
  Author: David Schinazi <DavidSchinazi@users.noreply.github.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  Merge pull request #86 from martinduke/version-zero

handle TP with version = 0


  Commit: 1bb184e905573dbab397f3c54f7c88594085aa40
      https://github.com/quicwg/version-negotiation/commit/1bb184e905573dbab397f3c54f7c88594085aa40
  Author: David Schinazi <dschinazi.ietf@gmail.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  Tweak QUICv1 compatibility requirements


  Commit: 12e976eea9a5d539df5e333c0462c7efca6d0dfe
      https://github.com/quicwg/version-negotiation/commit/12e976eea9a5d539df5e333c0462c7efca6d0dfe
  Author: David Schinazi <DavidSchinazi@users.noreply.github.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  Merge pull request #88 from quicwg/refactor_quicv1

Tweak QUICv1 compatibility requirements


  Commit: 639231ca42f969e855c26ada25f76a84253b4d01
      https://github.com/quicwg/version-negotiation/commit/639231ca42f969e855c26ada25f76a84253b4d01
  Author: David Schinazi <dschinazi.ietf@gmail.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  Reorder sections


  Commit: c09f9980b3cbf844a31e1595b5e3c647109a60eb
      https://github.com/quicwg/version-negotiation/commit/c09f9980b3cbf844a31e1595b5e3c647109a60eb
  Author: David Schinazi <DavidSchinazi@users.noreply.github.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  Merge pull request #89 from quicwg/reorder_sections

Reorder sections


  Commit: 0f1748c27aace62d8c683b202d7e7e0980528421
      https://github.com/quicwg/version-negotiation/commit/0f1748c27aace62d8c683b202d7e7e0980528421
  Author: David Schinazi <DavidSchinazi@users.noreply.github.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M draft-ietf-quic-version-negotiation.md

  Log Message:
  -----------
  Merge branch 'main' into v1_is_special


Compare: https://github.com/quicwg/version-negotiation/compare/c98a070131e0...0f1748c27aac