Re: [quicwg/base-drafts] Clarify QPACK eviction races (#1237)
Mike Bishop <notifications@github.com> Wed, 29 August 2018 17:48 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B227E130E71 for <quic-issues@ietfa.amsl.com>; Wed, 29 Aug 2018 10:48:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VMNdXPB499PF for <quic-issues@ietfa.amsl.com>; Wed, 29 Aug 2018 10:48:49 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D984D130DFD for <quic-issues@ietf.org>; Wed, 29 Aug 2018 10:48:48 -0700 (PDT)
Date: Wed, 29 Aug 2018 10:48:47 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1535564927; bh=S+MLKrmWOUtYo9tDz4fQYuqJe2oPJ1XrHja9eQdBoFM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=UaNkqS6ic1i0K2nGKjs6lb0QhHHs73BcgsvMlb/8KzCQ3lS1BthsTVqzfUjjVJ3Q8 RmDhI5cnSH+Fyu1HimlTE5QQK46SLcuSZZHR+BDxVi7exIcE53zcv5XLqzfF1BPZ6/ BtjOsYcFcafQ+tPBNlZSM2CFMium+oRfJczr0x28=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab38eb84be26b0a4aee6e7bb91a5b7fae9f206635e92cf00000001179e9e7f92a169ce12443a1c@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1237/review/150680046@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1237@github.com>
References: <quicwg/base-drafts/pull/1237@github.com>
Subject: Re: [quicwg/base-drafts] Clarify QPACK eviction races (#1237)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b86dc7fa4d37_601f3fd6842d45c0243e0"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/myBwXuxzlaXT3FgIZoPd8ToqoYE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Aug 2018 17:48:52 -0000
MikeBishop commented on this pull request. > +any eviction-prone entries, which are dynamic table entries that might be +evicted soon. Rather than reference an eviction-prone entry, the encoder SHOULD +emit an Indexed-Duplicate representation (see {{indexed-duplicate}}), and +reference the duplicate instead. + +To identify eviction-prone entries, the encoder can maintain a draining index, +which is the smallest absolute index in the dynamic table that it will emit a +reference for. As new entries are inserted, the encoder increments the +draining index such that the amount of free and draining space in the dyanmic +table is larger than its target threshold. + +~~~~~~~~~~ drawing + +----------------+-----------------------+------------+ + | Eviction-prone | Referenceable | Free Space | + | Entries | Entries | | + +----------------+-----------------------+------------+ I'm with @afrind. The pathological case I think you're describing is an encoder that won't / isn't permitted to block deciding that it should duplicate an old entry, but still can't use either one. If it doesn't duplicate it more than once, that should be okay. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1237#discussion_r213773851
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Mike Bishop
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Martin Thomson
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… afrind
- [quicwg/base-drafts] Clarify QPACK eviction races… afrind
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Martin Thomson
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… afrind
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Mike Bishop
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Mike Bishop
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… afrind
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… afrind
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Martin Thomson
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Martin Thomson
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… afrind
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Mike Bishop
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Martin Thomson
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… Martin Thomson
- Re: [quicwg/base-drafts] Clarify QPACK eviction r… afrind