Re: [quicwg/base-drafts] Version field <-> Version is not invariant (#3785)
Nick Harper <notifications@github.com> Mon, 06 July 2020 17:50 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 39F8E3A052C for <quic-issues@ietfa.amsl.com>; Mon, 6 Jul 2020 10:50:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.483
X-Spam-Level:
X-Spam-Status: No, score=-1.483 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wYzbA3RibUXZ for <quic-issues@ietfa.amsl.com>; Mon, 6 Jul 2020 10:50:37 -0700 (PDT)
Received: from out-26.smtp.github.com (out-26.smtp.github.com [192.30.252.209]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A0D713A0528 for <quic-issues@ietf.org>; Mon, 6 Jul 2020 10:50:37 -0700 (PDT)
Received: from github-lowworker-d93c4b6.va3-iad.github.net (github-lowworker-d93c4b6.va3-iad.github.net [10.48.17.47]) by smtp.github.com (Postfix) with ESMTP id DB055282CEC for <quic-issues@ietf.org>; Mon, 6 Jul 2020 10:50:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1594057836; bh=X0wBOdaHuxWFoLfvyU/8/+3nLchnaBZUElwzl7puRUI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=RVg+vXcJOLzDN1G5vy8D+aDpev6Xepi4PQAplasmRZ8P42VNlj14oI9d86hNtA3qI jrqpyOB+s6UmAX3n9FodU878fgUUw247XvcXCu1YjTVQ668Ed8IE2TOTRdRffVFURQ Nnp1Q83QeJoik6LQ2sSbC6qwA05IEjGFG7HyjS7A=
Date: Mon, 06 Jul 2020 10:50:36 -0700
From: Nick Harper <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYZZTJ7RGQF2USSTUN5B5CWZEVBNHHCMZ3PEU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3785/review/443289096@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3785@github.com>
References: <quicwg/base-drafts/pull/3785@github.com>
Subject: Re: [quicwg/base-drafts] Version field <-> Version is not invariant (#3785)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f03646ccc5bf_2d553fe26e0cd95c139722"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nharper
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/n7rrk-plRiI5ZZM5xj9zutisSC8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Jul 2020 17:50:39 -0000
@nharper commented on this pull request. > @@ -252,8 +252,9 @@ Packets for the same QUIC connection might use different connection ID values. ## Version -QUIC versions are identified with a 32-bit integer, encoded in network byte -order. Version 0 is reserved for version negotiation (see +The Version field contains a 32-bit integer, encoded in network byte order. I definitely agree we don't want something like the TLS notation. The only operation we need to do on QUIC versions (as encoded on the wire) is to check for equality. We don't need ordering of them (to check if one is less than another), and we certainly don't need to be able to do arithmetic on them, hence we don't need to consider them as numbers. By saying it's a 32-bit value (instead of an integer), we avoid needing to specify that it's network byte order. When specifying a version, you can write it out in hex (e.g. 0xff00001d), but that can be treated as a sequence of bytes instead of an integer. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3785#discussion_r450385198
- Re: [quicwg/base-drafts] Version field <-> Versio… ianswett
- [quicwg/base-drafts] Version field <-> Version is… Martin Thomson
- Re: [quicwg/base-drafts] Version field <-> Versio… Jana Iyengar
- Re: [quicwg/base-drafts] Version field <-> Versio… David Schinazi
- Re: [quicwg/base-drafts] Version field <-> Versio… Martin Thomson
- Re: [quicwg/base-drafts] Version field <-> Versio… Jana Iyengar
- Re: [quicwg/base-drafts] Version field <-> Versio… ekr
- Re: [quicwg/base-drafts] Version field <-> Versio… Martin Thomson
- Re: [quicwg/base-drafts] Version field <-> Versio… ekr
- Re: [quicwg/base-drafts] Version field <-> Versio… martinduke
- Re: [quicwg/base-drafts] Version field <-> Versio… Nick Harper
- Re: [quicwg/base-drafts] Version field <-> Versio… Martin Thomson
- Re: [quicwg/base-drafts] Version field <-> Versio… Martin Thomson
- Re: [quicwg/base-drafts] Version field <-> Versio… Nick Harper
- Re: [quicwg/base-drafts] Version field <-> Versio… Nick Harper
- Re: [quicwg/base-drafts] Version field <-> Versio… Martin Thomson
- Re: [quicwg/base-drafts] Version field <-> Versio… David Schinazi
- Re: [quicwg/base-drafts] Version field <-> Versio… Jana Iyengar
- Re: [quicwg/base-drafts] Version field <-> Versio… Martin Thomson
- Re: [quicwg/base-drafts] Version field <-> Versio… Martin Thomson
- Re: [quicwg/base-drafts] Version field <-> Versio… Martin Thomson
- Re: [quicwg/base-drafts] Version field <-> Versio… Nick Harper
- Re: [quicwg/base-drafts] Version field <-> Versio… Martin Thomson