IETF Logo Mail Archive

Re: [quicwg/base-drafts] Don't retransmit lost packets that are acked later (#3957)

ianswett <notifications@github.com> Tue, 28 July 2020 14:42 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4FBEF3A0DF9 for <quic-issues@ietfa.amsl.com>; Tue, 28 Jul 2020 07:42:15 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.555
X-Spam-Level:
X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pEsflSIvhXzz for <quic-issues@ietfa.amsl.com>; Tue, 28 Jul 2020 07:42:14 -0700 (PDT)
Received: from out-17.smtp.github.com (out-17.smtp.github.com [192.30.252.200]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 658573A0EAB for <quic-issues@ietf.org>; Tue, 28 Jul 2020 07:42:04 -0700 (PDT)
Received: from github-lowworker-1b8c660.ash1-iad.github.net (github-lowworker-1b8c660.ash1-iad.github.net [10.56.18.59]) by smtp.github.com (Postfix) with ESMTP id 7C35C5C0DC6 for <quic-issues@ietf.org>; Tue, 28 Jul 2020 07:42:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1595947323; bh=dRE6AE7kgJZTMT9BHi16ZYiwVS5yp8uVzNZNLs7mPFU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=YnnpcPLHmKoTWZGJhWTUTXBGCayMjuwaY6F34hlIsUzYuVDArIQse1FyuIOlG1qYC uu0OHg3HxhS7TOW0iI/f+S/6EoRvqNeEy8n7EgtNGCHhQgTht4rbuZ6qMSpREOq8Bq 5u84HhGI4xicwxnMvcflHrrCuhoj7hSgd3M2Xxo0=
Date: Tue, 28 Jul 2020 07:42:03 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3ND2MCKWFIEUO7MPF5FQNDXEVBNHHCPIKQDU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3957/review/456705456@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3957@github.com>
References: <quicwg/base-drafts/pull/3957@github.com>
Subject: Re: [quicwg/base-drafts] Don't retransmit lost packets that are acked later (#3957)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f20393b6d39f_121f3ffc4f2cd964594951"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/n96qdmC43ctkknZasYaCnT2AKQc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Jul 2020 14:42:15 -0000

@ianswett commented on this pull request.



> +acknowledged. This includes packets that are acknowledged after being declared
+lost. Doing so requires senders to retain information about packets after they
+are declared lost. A sender can discard this information after a period of time
+elapses, such as a PTO (Section 6.2 of {{QUIC-RECOVERY}}), or on other events,
+such as reaching a memory limit.

The intent was to both make it clearer and talk about the goal of waiting for a reordering period.  I find the existing text a bit unclear, which is why I put the first two sentences together.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3957#discussion_r461636266

v2.30.2 | Report a Bug | By Email | System Status