Re: [quicwg/base-drafts] incorrect error code used for invalid RETIRE_CONNECTION_ID frames (#3860)
Jana Iyengar <notifications@github.com> Mon, 13 July 2020 01:56 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9FA323A0802 for <quic-issues@ietfa.amsl.com>; Sun, 12 Jul 2020 18:56:23 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.153
X-Spam-Level:
X-Spam-Status: No, score=-0.153 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_16=1.048, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1hECIboj3oX6 for <quic-issues@ietfa.amsl.com>; Sun, 12 Jul 2020 18:56:22 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6A1413A080B for <quic-issues@ietf.org>; Sun, 12 Jul 2020 18:56:21 -0700 (PDT)
Received: from github-lowworker-fa7043e.ash1-iad.github.net (github-lowworker-fa7043e.ash1-iad.github.net [10.56.109.45]) by smtp.github.com (Postfix) with ESMTP id 7413E8C0348 for <quic-issues@ietf.org>; Sun, 12 Jul 2020 18:56:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1594605380; bh=6K4YOXGNG8Xt/3FmGXriJJO5CZlcvFZNdkeHXZkwfx0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=l26yyR0MqzuopNW3X4NIxbJ8SEKYd+eeX2+kY6VSgG7xr+WsPdl23EfOmKwfkiw1A Co7hZletT7biz0IRSJlOl1dX3YcTQ97h0OyO0gCE6iiwucex6h4DxYbK0uOhBqn/Sf zbBHCBXV7qAPRwLKfGp3ML+9UaNwwfjOHbFbV8DM=
Date: Sun, 12 Jul 2020 18:56:20 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK34CRAO6PAIRCWUVW55C6QEJEVBNHHCN23WDA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3860/657318469@github.com>
In-Reply-To: <quicwg/base-drafts/issues/3860@github.com>
References: <quicwg/base-drafts/issues/3860@github.com>
Subject: Re: [quicwg/base-drafts] incorrect error code used for invalid RETIRE_CONNECTION_ID frames (#3860)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f0bbf4464df2_17b83f93a66cd9689251d6"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/nBp9NQaxVpdNGBadkB59QSWWFTQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jul 2020 01:56:24 -0000
As I noted in the PR, I agree that PROTOCOL_VIOLATION seems like a more appropriate error. In addition to @marten-seemann's point, this is a semantic error, not one of encoding (which suggests syntactic). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/issues/3860#issuecomment-657318469
- Re: [quicwg/base-drafts] incorrect error code use… Martin Thomson
- [quicwg/base-drafts] incorrect error code used fo… Marten Seemann
- Re: [quicwg/base-drafts] incorrect error code use… Lucas Pardue
- Re: [quicwg/base-drafts] incorrect error code use… ianswett
- Re: [quicwg/base-drafts] incorrect error code use… Jana Iyengar
- Re: [quicwg/base-drafts] incorrect error code use… Lars Eggert
- Re: [quicwg/base-drafts] incorrect error code use… Martin Thomson
- Re: [quicwg/base-drafts] incorrect error code use… Dmitri Tikhonov