Re: [quicwg/base-drafts] QPACK: make TSS=0 a connection error (#1762)

Dmitri Tikhonov <notifications@github.com> Tue, 18 September 2018 20:45 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6B834130E82 for <quic-issues@ietfa.amsl.com>; Tue, 18 Sep 2018 13:45:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.01
X-Spam-Level:
X-Spam-Status: No, score=-3.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hz4sxWFPJoW2 for <quic-issues@ietfa.amsl.com>; Tue, 18 Sep 2018 13:44:59 -0700 (PDT)
Received: from o8.sgmail.github.com (o8.sgmail.github.com [167.89.101.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 39CFD130E47 for <quic-issues@ietf.org>; Tue, 18 Sep 2018 13:44:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=RyhgVhWZ23T/T8K8LPh7o788LuE=; b=SIEVZhPhCQM6VTpu oChYfwDeqW9WahYoUuBGHIoHrevlthMRMh/slocgkFfcXKH50/dzpCdBI9pOepw6 OK2YLmqyqZH6Q2PDzKV3fKD6S8Yv/aiNGLOy8vHCiFEv6XZJGCXdAg1AvNlecywv lUV1IC7aDcwfFHbvGqiss+F9bVw=
Received: by filter0023p1iad2.sendgrid.net with SMTP id filter0023p1iad2-19914-5BA163C8-2B 2018-09-18 20:44:56.981997331 +0000 UTC m=+1030715.365423869
Received: from github-lowworker-89d05ac.cp1-iad.github.net (unknown [192.30.252.35]) by ismtpd0003p1iad1.sendgrid.net (SG) with ESMTP id s9QwArkkSimKjI-KkV0gOg for <quic-issues@ietf.org>; Tue, 18 Sep 2018 20:44:57.003 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-89d05ac.cp1-iad.github.net (Postfix) with ESMTP id F2005AE01E0 for <quic-issues@ietf.org>; Tue, 18 Sep 2018 13:44:56 -0700 (PDT)
Date: Tue, 18 Sep 2018 20:44:57 +0000
From: Dmitri Tikhonov <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab7b9f3cd380c8ab949ce8bc0ce2e58762a3b072e292cf0000000117b925c892a169ce158602f3@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1762/review/156560806@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1762@github.com>
References: <quicwg/base-drafts/pull/1762@github.com>
Subject: Re: [quicwg/base-drafts] QPACK: make TSS=0 a connection error (#1762)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ba163c8ec6a4_33383fe845cd45c050879f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: dtikhonov
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3SrH/faq6+GPiKsyXv06i11diBHZr4xsFLpa 7cWjl3oVU4Ky9Nvla5H/s/P6jvGVcWObm0qf6H+clUZdlybMfkkWWrZS9WgKuP5VjzDIdhUaLZpXF5 mUyIV+wKuaovopfYnVGyZAtYwW5tzvfcfK2OWkKlnQU6NxsquY23zssnzGFOILhFbtfzCAgJuDUUNS U=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/nGoJCB79MXy35asjpX-XMzqc6ao>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Sep 2018 20:45:03 -0000

dtikhonov commented on this pull request.



> @@ -587,9 +587,10 @@ entries might cause a stream to become blocked, as described in
 ~~~~~~~~~~
 {:#fig-size-sync title="Table State Synchronize"}
 
-An encoder that receives an Insert Count that is greater than the number of
-dynamic table entries beyond the current Largest Known Received entry MUST treat
-this as a connection error of type `HTTP_QPACK_DECODER_STREAM_ERROR`.
+An encoder that receives an Insert Count equal to zero, or that is greater than

Perhaps something along the lines of:

> The Insert Count value cannot be zero and it cannot be greater than the current Largest Known Received value.  An encoder that receives an invalid Insert Count value MUST treat it...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1762#discussion_r218588228