IETF Logo Mail Archive

Re: [quicwg/base-drafts] don't allow 0 as a packet number (#832)

Marten Seemann <notifications@github.com> Wed, 04 October 2017 13:46 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 88AF01342CE for <quic-issues@ietfa.amsl.com>; Wed, 4 Oct 2017 06:46:33 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.181
X-Spam-Level:
X-Spam-Status: No, score=-3.181 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-2.8, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aNoqcI2XnZ2r for <quic-issues@ietfa.amsl.com>; Wed, 4 Oct 2017 06:46:32 -0700 (PDT)
Received: from o6.sgmail.github.com (o6.sgmail.github.com [192.254.113.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 77A27134218 for <quic-issues@ietf.org>; Wed, 4 Oct 2017 06:46:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=vh6i1Z+EdxfRH3Yt9SBPabREFQ8=; b=vXSvwyiCUeCrYsVn 0TSR2vtMqxs7Q+VDs9NfiiFcC/AGlsESfYoJfL9/hiU7hDVDz1ZZ2v9GTZDt/+li KjvEW1pRDMhW9jrtFCHrRXV78tqx+nqgcKe8pt1o17PWcgo3UcM4I4h8Oda+VGPS mV8KPX0qOS60ALXDUoUGs7EzAHw=
Received: by filter0216p1iad2.sendgrid.net with SMTP id filter0216p1iad2-9449-59D4E634-5B 2017-10-04 13:46:28.700850273 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0002p1iad2.sendgrid.net (SG) with ESMTP id iDv7qKKTRc6AXQj14zUefA for <quic-issues@ietf.org>; Wed, 04 Oct 2017 13:46:28.739 +0000 (UTC)
Date: Wed, 04 Oct 2017 13:46:28 +0000
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab56e25fd38204e8748406966cafb7176b6231156692cf0000000115eca83492a169ce0fa74d75@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/832/334160224@github.com>
In-Reply-To: <quicwg/base-drafts/issues/832@github.com>
References: <quicwg/base-drafts/issues/832@github.com>
Subject: Re: [quicwg/base-drafts] don't allow 0 as a packet number (#832)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_59d4e6348a7ed_57433fdfb532ef2c507d7"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3/icV9BsC53NQkRCNlBD3Oi+oEw+ptdLhSaR +LeUaebBZelCJVT9I6IDnapsbBsdcA4cvfxRuG71DbSgLkCtMZr5M5NTU5K2uN+pqyPQwLUDX1w510 eFWZKXF+IqeZiUVOfhJj4kEwLVYSD1a2ZNpEHEl5mNRr8nOqwptiO03yu/exwhRXXRAmtiBuXZu+Ao M=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/nJBp4xuvisjM6iQodCxdrSw1JWM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Oct 2017 13:46:33 -0000

That's a little extra logic (one if for generating and one if for receiving). By allowing 0 with the probability of 2^-31 we lose the ability to check that `highest received packet number != 0`, which will already is problem for several implementations, and will produce some really nasty corner cases in the future.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/832#issuecomment-334160224

v2.46.0 | Report a Bug | By Email | System Status