Re: [quicwg/base-drafts] Avoid data corruption with wrapped Largest Reference. (#2261)

[Mike Bishop <[e-mail]>]

MikeBishop approved this pull request.

This looks reasonable.

>  An encoder MUST NOT insert an entry into the dynamic table (or duplicate an
-existing entry) if doing so would evict an entry with unacknowledged references.
-For header blocks that might rely on the newly added entry, the encoder can use
-a literal representation and maybe insert the entry later.
+existing entry) if doing so would evict a blocking entry.  For header blocks
+that would rely on the newly added entry, the encoder can instead use a literal
+representation and maybe insert the entry later.

With the added language, this line feels more ambiguous about which "the entry" is being referenced.  (Of course, it was somewhat ambiguous before.)  Maybe just drop the "and maybe insert the entry later"?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2261#pullrequestreview-190388996