Re: [quicwg/base-drafts] Don't store or retransmit PATH_RESPONSE frames, avoid buffering (#2729)
Mike Bishop <notifications@github.com> Tue, 11 June 2019 17:46 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8840F120048 for <quic-issues@ietfa.amsl.com>; Tue, 11 Jun 2019 10:46:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.008
X-Spam-Level:
X-Spam-Status: No, score=-8.008 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mQl3yxpEVQ83 for <quic-issues@ietfa.amsl.com>; Tue, 11 Jun 2019 10:46:01 -0700 (PDT)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E92D712012A for <quic-issues@ietf.org>; Tue, 11 Jun 2019 10:45:57 -0700 (PDT)
Date: Tue, 11 Jun 2019 10:45:57 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1560275157; bh=vsYl1tDSPMtQnRWODOZnWmAn0ax9oYL5LmYgFqulDYk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=HB+MRyICvhohWyZW6VG+TrYBZrMu/Jl51tdULOuJKr9opQB/Gf85nLmkwM6fFhecp Lcx4k/1RFhVBCfbxjn0/AIJ4I7Ru+BNouyruq+JsZN4qGdZZ+2572PvXyFYkEdWe/9 u5DrwzCnmfWc8KHg+o9sLOkXWUq4GVbexPJeL5nE=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKY7DVAYBZDED6XH7UF3BUNVLEVBNHHBVGEZF4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2729/review/248337699@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2729@github.com>
References: <quicwg/base-drafts/pull/2729@github.com>
Subject: Re: [quicwg/base-drafts] Don't store or retransmit PATH_RESPONSE frames, avoid buffering (#2729)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cffe8d526123_3bc03f96c72cd95c44593d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/nOcHWXwpZVY8daM_nau5KQQEyUg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Jun 2019 17:46:02 -0000
MikeBishop commented on this pull request. > @@ -1721,7 +1721,12 @@ it can associate the peer's response with the corresponding PATH_CHALLENGE. ## Path Validation Responses On receiving a PATH_CHALLENGE frame, an endpoint MUST respond immediately by -echoing the data contained in the PATH_CHALLENGE frame in a PATH_RESPONSE frame. +echoing the data contained in the PATH_CHALLENGE frame in a PATH_RESPONSE frame, +unless it has PATH_RESPONSE frames buffered for the same destination connection +ID and wishes to limit memory consumption. + +An endpoint MUST NOT store or retransmit a PATH_RESPONSE frame, as a new +PATH_CHALLENGE frame will be sent if another PATH_RESPONSE frame is needed. Do we have precedent for a fixed number of something allowed in a packet? We've previously said multiple ACKs isn't best practice, but it's not prohibited. This feels similar -- adding a new type of prohibition for something not actively harmful seems excessive. Simply don't require them to be processed, and let implementations choose. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2729#discussion_r292581950
- [quicwg/base-drafts] Don't store or retransmit PA… Eric Kinnear
- Re: [quicwg/base-drafts] Don't store or retransmi… Martin Thomson
- Re: [quicwg/base-drafts] Don't store or retransmi… Eric Kinnear
- Re: [quicwg/base-drafts] Don't store or retransmi… ianswett
- Re: [quicwg/base-drafts] Don't store or retransmi… Eric Kinnear
- Re: [quicwg/base-drafts] Don't store or retransmi… Eric Kinnear
- Re: [quicwg/base-drafts] Don't store or retransmi… Rui Paulo
- Re: [quicwg/base-drafts] Don't store or retransmi… Eric Kinnear
- Re: [quicwg/base-drafts] Don't store or retransmi… Eric Kinnear
- Re: [quicwg/base-drafts] Don't store or retransmi… Eric Kinnear
- Re: [quicwg/base-drafts] Don't store or retransmi… Martin Thomson
- Re: [quicwg/base-drafts] Don't store or retransmi… Eric Kinnear
- Re: [quicwg/base-drafts] Don't store or retransmi… Eric Kinnear
- Re: [quicwg/base-drafts] Don't store or retransmi… MikkelFJ
- Re: [quicwg/base-drafts] Don't store or retransmi… Eric Kinnear
- Re: [quicwg/base-drafts] Don't store or retransmi… Kazuho Oku
- Re: [quicwg/base-drafts] Don't store or retransmi… MikkelFJ
- Re: [quicwg/base-drafts] Don't store or retransmi… Dmitri Tikhonov
- Re: [quicwg/base-drafts] Don't store or retransmi… David Schinazi
- Re: [quicwg/base-drafts] Don't store or retransmi… Jana Iyengar
- Re: [quicwg/base-drafts] Don't store or retransmi… Mike Bishop
- Re: [quicwg/base-drafts] Don't store or retransmi… ianswett
- Re: [quicwg/base-drafts] Don't store or retransmi… David Schinazi
- Re: [quicwg/base-drafts] Don't store or retransmi… Eric Kinnear
- Re: [quicwg/base-drafts] Don't store or retransmi… Eric Kinnear
- Re: [quicwg/base-drafts] Don't store or retransmi… Eric Kinnear
- Re: [quicwg/base-drafts] Don't store or retransmi… ianswett
- Re: [quicwg/base-drafts] Don't store or retransmi… MikkelFJ
- Re: [quicwg/base-drafts] Don't store or retransmi… Dmitri Tikhonov
- Re: [quicwg/base-drafts] Don't store or retransmi… Mike Bishop
- Re: [quicwg/base-drafts] Don't store or retransmi… Yang Chi
- Re: [quicwg/base-drafts] Don't store or retransmi… ianswett
- Re: [quicwg/base-drafts] Don't store or retransmi… Yang Chi
- Re: [quicwg/base-drafts] Don't store or retransmi… ianswett
- Re: [quicwg/base-drafts] Don't store or retransmi… Yang Chi
- Re: [quicwg/base-drafts] Don't store or retransmi… Martin Thomson
- Re: [quicwg/base-drafts] Don't store or retransmi… Martin Thomson
- Re: [quicwg/base-drafts] Don't store or retransmi… MikkelFJ
- Re: [quicwg/base-drafts] Don't store or retransmi… Kazuho Oku
- Re: [quicwg/base-drafts] Don't store or retransmi… ianswett
- Re: [quicwg/base-drafts] Don't store or retransmi… David Schinazi
- Re: [quicwg/base-drafts] Don't store or retransmi… Eric Kinnear
- Re: [quicwg/base-drafts] Don't store or retransmi… Eric Kinnear
- Re: [quicwg/base-drafts] Don't store or retransmi… Eric Kinnear
- Re: [quicwg/base-drafts] Don't store or retransmi… Eric Kinnear
- Re: [quicwg/base-drafts] Don't store or retransmi… Eric Kinnear
- Re: [quicwg/base-drafts] Don't store or retransmi… MikkelFJ
- Re: [quicwg/base-drafts] Don't store or retransmi… Eric Kinnear
- Re: [quicwg/base-drafts] Don't store or retransmi… Eric Kinnear
- Re: [quicwg/base-drafts] Don't store or retransmi… Eric Kinnear
- Re: [quicwg/base-drafts] Don't store or retransmi… David Schinazi
- Re: [quicwg/base-drafts] Don't store or retransmi… ianswett
- Re: [quicwg/base-drafts] Don't store or retransmi… Jana Iyengar
- Re: [quicwg/base-drafts] Don't store or retransmi… Jana Iyengar
- Re: [quicwg/base-drafts] Don't store or retransmi… Eric Kinnear
- Re: [quicwg/base-drafts] Don't store or retransmi… Eric Kinnear
- Re: [quicwg/base-drafts] Don't store or retransmi… Eric Kinnear
- Re: [quicwg/base-drafts] Don't store or retransmi… Martin Thomson