Re: [quicwg/base-drafts] Conflicting error codes (#4087)
Marten Seemann <notifications@github.com> Tue, 15 September 2020 01:08 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AE5AC3A0BC1 for <quic-issues@ietfa.amsl.com>; Mon, 14 Sep 2020 18:08:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.794
X-Spam-Level:
X-Spam-Status: No, score=-4.794 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.695, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iQNV0LRXvIJE for <quic-issues@ietfa.amsl.com>; Mon, 14 Sep 2020 18:08:41 -0700 (PDT)
Received: from out-26.smtp.github.com (out-26.smtp.github.com [192.30.252.209]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5B1883A0BC0 for <quic-issues@ietf.org>; Mon, 14 Sep 2020 18:08:41 -0700 (PDT)
Received: from github-lowworker-fb56993.ac4-iad.github.net (github-lowworker-fb56993.ac4-iad.github.net [10.52.19.31]) by smtp.github.com (Postfix) with ESMTP id 7D71F5E007D for <quic-issues@ietf.org>; Mon, 14 Sep 2020 18:08:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1600132120; bh=d3VI8uyH7yCooGPtwQnDB5Nq9kXgVS86BwoDfZvYOGw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=LFKbvSLpMLN6d/4n3ZJvBGvd7wnjxVrcvbIc4RaX8ue1gM4n3fUDn7dn/516d8Hgg 8k4t2drI7NVDJs6ORjS9EbFHit8mUFHacMhYA1cS+aI5nFoMDyk2SqnqWeZhLGRnxQ SJMVzx65fpEtGIPyaWeTxapj+WdoSMmam0gg8KrE=
Date: Mon, 14 Sep 2020 18:08:40 -0700
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7KB5HSVI35ZRPFTFV5NP2RREVBNHHCTETOJE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/4087/692399479@github.com>
In-Reply-To: <quicwg/base-drafts/issues/4087@github.com>
References: <quicwg/base-drafts/issues/4087@github.com>
Subject: Re: [quicwg/base-drafts] Conflicting error codes (#4087)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f6014186d273_5ab719f0760ef"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/nOp8mYDL2v74aTlFzPRkpbmYWBA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Sep 2020 01:08:43 -0000
@huitema There's another condition where KEY_UPDATE_ERROR might occur: If you acknowledge a packet in key phase N+1 using key phase N. It's just a MAY in the specification though (I don't know why, this should be trivial to implement): > An endpoint that receives an acknowledgement that is carried in a packet protected with old keys where any acknowledged packet was protected with newer keys MAY treat that as a connection error of type KEY_UPDATE_ERROR. This indicates that a peer has received and acknowledged a packet that initiates a key update, but has not updated keys in response. @huitema > I can't wait to see the first error report in which some poor dude tries to transmit more than 50GB over a QUIC connection and hits a bug in the implementation of key update... That's why we recently added a key update test to the interop runner. Unfortunately, it looks like a number of implementations (even those that already boasted about rolling out QUIC into production) treat key updates as some kind of optional feature, which it isn't. This is bad, as this now prevents others from rolling out QUIC implementations that initiate a key update early in the connection to exercise the mechanism. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/issues/4087#issuecomment-692399479
- [quicwg/base-drafts] Conflicting error codes (#40… Tatsuhiro Tsujikawa
- Re: [quicwg/base-drafts] Conflicting error codes … Marten Seemann
- Re: [quicwg/base-drafts] Conflicting error codes … Martin Thomson
- Re: [quicwg/base-drafts] Conflicting error codes … David Schinazi
- Re: [quicwg/base-drafts] Conflicting error codes … ekr
- Re: [quicwg/base-drafts] Conflicting error codes … Jana Iyengar
- Re: [quicwg/base-drafts] Conflicting error codes … Christian Huitema
- Re: [quicwg/base-drafts] Conflicting error codes … Jana Iyengar
- Re: [quicwg/base-drafts] Conflicting error codes … Christian Huitema
- Re: [quicwg/base-drafts] Conflicting error codes … Jana Iyengar
- Re: [quicwg/base-drafts] Conflicting error codes … Christian Huitema
- Re: [quicwg/base-drafts] Conflicting error codes … Marten Seemann
- Re: [quicwg/base-drafts] Conflicting error codes … Martin Thomson
- Re: [quicwg/base-drafts] Conflicting error codes … Marten Seemann
- Re: [quicwg/base-drafts] Conflicting error codes … Christian Huitema
- Re: [quicwg/base-drafts] Conflicting error codes … Marten Seemann
- Re: [quicwg/base-drafts] Conflicting error codes … David Schinazi
- Re: [quicwg/base-drafts] Conflicting error codes … Martin Thomson