Re: [quicwg/base-drafts] Remove the explicit packet number gap in favor of one computed (#496)

Martin Thomson <notifications@github.com> Thu, 04 May 2017 01:27 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 67C7B129490 for <quic-issues@ietfa.amsl.com>; Wed, 3 May 2017 18:27:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.397
X-Spam-Level:
X-Spam-Status: No, score=-3.397 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-2.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Wqtvvu60jyHO for <quic-issues@ietfa.amsl.com>; Wed, 3 May 2017 18:27:58 -0700 (PDT)
Received: from o4.sgmail.github.com (o4.sgmail.github.com [192.254.112.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 19500129481 for <quic-issues@ietf.org>; Wed, 3 May 2017 18:27:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=E9U3K4yPsWiLUffiGgNpVqi6adk=; b=ForJoHHRtKKGwTmT c+1n5jAII3yn/dB+A7fDjNuyUXvYnpg52IYMslpJu6C8vFXjY+jwP1K8hc5otXEG 16jl0O3Tsf1SERCb+fzjIKLZ8N/LI8SmhmnHtNHUNDF1nvR8gurBmYXI3Mh6ILhO sJO0M6b0NMLFAwLu3hnHqF3eF2k=
Received: by filter0538p1mdw1.sendgrid.net with SMTP id filter0538p1mdw1-26483-590A839B-45 2017-05-04 01:27:55.67109326 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0001p1iad1.sendgrid.net (SG) with ESMTP id kUtaZEPaT4SKymqCGD5Nhg for <quic-issues@ietf.org>; Thu, 04 May 2017 01:27:55.633 +0000 (UTC)
Date: Wed, 03 May 2017 18:27:55 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abe662f258c6fd46b8ad705aaaf54bd777693b2fbb92cf000000011522459b92a169ce0d7957f1@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/496/review/36174921@github.com>
In-Reply-To: <quicwg/base-drafts/pull/496@github.com>
References: <quicwg/base-drafts/pull/496@github.com>
Subject: Re: [quicwg/base-drafts] Remove the explicit packet number gap in favor of one computed (#496)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_590a839b879f4_42b63fac0b4e9c3c57375"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1R/NGpG3IDGhLfPH5RVKFVpK2Z/4Cep69dm2 Zm67V6vXBtsj2rwuMF9W9yZj42K1W26GuFRjXC6AUbuKzFYz2JAQINUONQRXL5qtIF/8Kv5IhtXR/U uvAnG6OfrCyn1uC0oYomGulgXuM+vjwnCSAMhuWz15/CJYH0cnx3ipilIW8TlxdUbdfkhKT7bPjDvZ M=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/nXZlR7z0IkU4oue0NkCFD3sS4_k>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 04 May 2017 01:27:59 -0000

martinthomson commented on this pull request.



> @@ -1296,6 +1291,22 @@ connection ID, it should expect packets on the new connection ID to start at 18.
 A packet with the new connection ID and a packet number of 17 is discarded as
 being in error.
 
+#### Packet Number Gap
+
+In order to avoid linkage, the packet number gap MUST be externally
+indistinguishable from random. The packet number gap for a connection
+ID with sequence number is computed by encoding the sequence number
+as a 32-bit integer in big-endian format, and then computing:
+
+~~~
+Gap = HKDF-Expand-Label(packet_number_secret,
+                        "QUIC packet sequence gap", sequence, 4)

If we move packet protection to the transport, as planned, then we'll need HKDF, so there's no real issue with taking this change as it is.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/496#discussion_r114687492