Re: [quicwg/base-drafts] handle reordered NEW_CONNECTION_ID frames (#3202)

Eric Kinnear <> Thu, 07 November 2019 18:41 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id 706C61200B5 for <>; Thu, 7 Nov 2019 10:41:21 -0800 (PST)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id dk5dZjmTBJ2H for <>; Thu, 7 Nov 2019 10:41:20 -0800 (PST)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id CF8D31200B4 for <>; Thu, 7 Nov 2019 10:41:19 -0800 (PST)
Received: from ( []) by (Postfix) with ESMTP id C66EE521AA9 for <>; Thu, 7 Nov 2019 10:41:18 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1573152078; bh=XrXB0JVD63A06rd7nnGRjq87BJJIarO8Gu2HTx+QPAk=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=V/x2Tws3oANnp7gw+shF5mR1dKoURo3qXVd67K34+sWNv1oDEhWN7va3ouNfACzSQ aSiTISjBNt/PSt+UiCH+8soA85a115OPIAngXtR63VKIMxG0nno2dwpqiQdVRFTrde E/3kVs6vMgtPp7DRA0ORIkojY8LQBz21crU/HOvI=
Date: Thu, 07 Nov 2019 10:41:18 -0800
From: Eric Kinnear <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/3202/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] handle reordered NEW_CONNECTION_ID frames (#3202)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dc4654eb64fe_5bf3fd478ecd95c7128f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: erickinnear
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Thu, 07 Nov 2019 18:41:22 -0000

erickinnear approved this pull request.

Small tweak to @ianswett's wording suggestion, but otherwise looks good!

> @@ -5398,6 +5398,10 @@ and preferred_address transport parameter connection IDs.  The peer SHOULD
 retire the corresponding connection IDs and send the corresponding
 RETIRE_CONNECTION_ID frames in a timely manner.
+An endpoint that receives a NEW_CONNECTION_ID frame with a sequence number
+smaller than the Retire Prior To field of a NEW_CONNECTION_ID frame received
+before, MUST immediately send a corresponding RETIRE_CONNECTION_ID frame.

I would potentially also add
MUST immediately send a corresponding RETIRE_CONNECTION_ID frame that 
retires the newly received connection ID.
Since there's two NCID frames being referenced here.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: