Re: [quicwg/base-drafts] Rename Final Offset to Final Size (#2285)

janaiyengar <notifications@github.com> Fri, 04 January 2019 01:40 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6DFA01274D0 for <quic-issues@ietfa.amsl.com>; Thu, 3 Jan 2019 17:40:03 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.661
X-Spam-Level:
X-Spam-Status: No, score=-6.661 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dZJ33pc5rdyc for <quic-issues@ietfa.amsl.com>; Thu, 3 Jan 2019 17:40:01 -0800 (PST)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9F86412D4EB for <quic-issues@ietf.org>; Thu, 3 Jan 2019 17:40:01 -0800 (PST)
Date: Thu, 03 Jan 2019 17:40:00 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1546566000; bh=GMUTjBXpv2KNT8x4wBMD8G7ZQ5tf7c0RCfUkDQ38FgA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=hvZMZr+rjy9CGrs6NsevR8G+0JNX79A4z50Hb5iLpkn+DFaEqlWA1P8ec2QVDI2rZ FnZhefboQwZwWI4eJlxqaz/VHOqTByMjFRcE1qHWO3SGCCcl9jGtZUUGCENmxN4RkO mzpmC8zQAMs82Ayb9HsOg1McSBUNEEq/kGiu6nIY=
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4aba835dbf6a7f3b98b9639dad103fc7de95086b18f92cf0000000118467b7092a169ce1791b3a4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2285/review/189244548@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2285@github.com>
References: <quicwg/base-drafts/pull/2285@github.com>
Subject: Re: [quicwg/base-drafts] Rename Final Offset to Final Size (#2285)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c2eb97081c66_50873f80588d45c41645a5"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/nik4RJkKOv_13Qle5STz4EAxrnE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Jan 2019 01:40:04 -0000

janaiyengar commented on this pull request.



>  
-An endpoint will know the final offset for a stream when the receiving part of
-the stream enters the "Size Known" or "Reset Recvd" state ({{stream-states}}).
+For a
+stream that is reset, the final size is carried explicitly in a RESET_STREAM
+frame.  Otherwise, the final size is the offset plus the length of a STREAM

It might be worth adding that for a stream that is reset, the final size might be smaller than the number of bytes sent on the stream.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2285#pullrequestreview-189244548