Date: Mon, 30 Mar 2020 07:20:49 -0700
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK4B6YFBP6PYBI4BY2F4RXQUDEVBNHHCGDM7NY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3546/606028967@github.com>
In-Reply-To: <quicwg/base-drafts/issues/3546@github.com>
References: <quicwg/base-drafts/issues/3546@github.com>
Subject: Re: [quicwg/base-drafts] PTO probes are sent too frequently (#3546)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5e820041789f5_42683f7e264cd9644945c1";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/nj2gWiIF5PGd5P67iPz2ybD9WLk>


----==_mimepart_5e820041789f5_42683f7e264cd9644945c1
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

I updated the PR to only do this for the client, since I think that's the right thing to do.

I did the Initial check because I thought it was slightly simpler than the `peer not awaiting address validation` check, which I believe is equivalent, since receiving an Initial ACK means you still have Initial keys, so the server is awaiting address validation.  As soon as a Handshake ACK is received by the client, it knows the server has completed address validation.

But I could also use the PeerNotAwaitingAddressValidation() method that's already defined(and mistakenly not used, see #3555 

Then I think the check would be:
```
If (PeerNotAwaitingAddressValidation())
  pto_count = 0
```
   

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3546#issuecomment-606028967
----==_mimepart_5e820041789f5_42683f7e264cd9644945c1
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p></p>
<p>I updated the PR to only do this for the client, since I think that's the right thing to do.</p>
<p>I did the Initial check because I thought it was slightly simpler than the <code>peer not awaiting address validation</code> check, which I believe is equivalent, since receiving an Initial ACK means you still have Initial keys, so the server is awaiting address validation.  As soon as a Handshake ACK is received by the client, it knows the server has completed address validation.</p>
<p>But I could also use the PeerNotAwaitingAddressValidation() method that's already defined(and mistakenly not used, see <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="590329323" data-permission-text="Title is private" data-url="https://github.com/quicwg/base-drafts/issues/3555" data-hovercard-type="pull_request" data-hovercard-url="/quicwg/base-drafts/pull/3555/hovercard" href="https://github.com/quicwg/base-drafts/pull/3555">#3555</a></p>
<p>Then I think the check would be:</p>
<pre><code>If (PeerNotAwaitingAddressValidation())
  pto_count = 0
</code></pre>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/issues/3546#issuecomment-606028967">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK7UBPCGBRIVOEJ6FJ3RKCTEDANCNFSM4LT4F2OA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJK4GD7UYRWQYXYBYJKTRKCTEDA5CNFSM4LT4F2OKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEQPUJJY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/issues/3546#issuecomment-606028967",
"url": "https://github.com/quicwg/base-drafts/issues/3546#issuecomment-606028967",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5e820041789f5_42683f7e264cd9644945c1--