Re: [quicwg/base-drafts] Allow servers to send a preferred address of each address family (#2296)

David Schinazi <notifications@github.com> Wed, 09 January 2019 20:57 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 996FD130F33 for <quic-issues@ietfa.amsl.com>; Wed, 9 Jan 2019 12:57:42 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.935
X-Spam-Level:
X-Spam-Status: No, score=-5.935 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IPv6gTbMamwY for <quic-issues@ietfa.amsl.com>; Wed, 9 Jan 2019 12:57:41 -0800 (PST)
Received: from o8.sgmail.github.com (o8.sgmail.github.com [167.89.101.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0FFA2130EAB for <quic-issues@ietf.org>; Wed, 9 Jan 2019 12:57:40 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=OrOA9IWWCw1MIg70RFe0CZfha0g=; b=aYON499INvHP+Wbw aKAE3VvjVJAGwkj+ThSUVBoJwZUan2Zw+otdADqPnHzZG2K/0GH5Elwy0z5Er3DD yi/Mn/o7ZsnuM2T4hxOLNncWGJgSdzUyfXhGkvKME8rglGwNLFA4nJzCstHXJL34 wD4PEjAizhl8+RG+g23QYBEGLg4=
Received: by filter1753p1mdw1.sendgrid.net with SMTP id filter1753p1mdw1-4520-5C366042-C 2019-01-09 20:57:38.259410973 +0000 UTC m=+155832.918574373
Received: from github-lowworker-97d0962.cp1-iad.github.net (unknown [192.30.252.41]) by ismtpd0036p1mdw1.sendgrid.net (SG) with ESMTP id NzgwK5RNSCCVgtcv9Wys5A for <quic-issues@ietf.org>; Wed, 09 Jan 2019 20:57:38.260 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-97d0962.cp1-iad.github.net (Postfix) with ESMTP id B7ECB80C5E for <quic-issues@ietf.org>; Wed, 9 Jan 2019 12:57:37 -0800 (PST)
Date: Wed, 09 Jan 2019 20:57:38 +0000
From: David Schinazi <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab6de797e378acb3e572566cfab36226e7672c39c592cf00000001184e224192a169ce179bec73@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2296/review/190897303@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2296@github.com>
References: <quicwg/base-drafts/pull/2296@github.com>
Subject: Re: [quicwg/base-drafts] Allow servers to send a preferred address of each address family (#2296)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c366041b4457_58993fc4ffad45b812993f0"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: DavidSchinazi
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1yVGst1Yg9zSx7e4Zm6rwOXj9P4BjO0eb24/ PnO2ZEqLlewD0Ts3tBIUlDm3u0M3oxSU2J+4zbLslConHTc0eR7dCeHgjjNGaaBrnD4nGsgX47/nkD 1MGep4Pm9I0B0XcVc0r3eLFGZVZEYxfsAQy8rVJsF2LsuGm9Wi34gKdhOUErePthvDTCDs6yyV7Hf1 w=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/npSrmG3NPWLHYG_1zhH-Y0PsZDA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Jan 2019 20:57:43 -0000

DavidSchinazi commented on this pull request.



>  
 ~~~
    struct {
-     enum { IPv4(4), IPv6(6), (15) } ipVersion;
-     opaque ipAddress<4..2^8-1>;
+     opaque ipv4Address<0..2^8-1>;
+     opaque ipv6Address<0..2^8-1>;
      uint16 port;

The latest version has separate ports, see the diff.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2296#discussion_r246515143