Re: [quicwg/base-drafts] introduce a max_connection_ids transport parameter (#1998)

ianswett <> Wed, 19 December 2018 14:28 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id B7C711274D0 for <>; Wed, 19 Dec 2018 06:28:34 -0800 (PST)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -8.065
X-Spam-Status: No, score=-8.065 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id zVdSDqKLDjb0 for <>; Wed, 19 Dec 2018 06:28:33 -0800 (PST)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id BD1121200B3 for <>; Wed, 19 Dec 2018 06:28:32 -0800 (PST)
Date: Wed, 19 Dec 2018 06:28:31 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1545229711; bh=C5PN22eD430TVuYyk3OixCXLZ93YL9hExeS+Vlqzzj8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=lVLwRKvgFPL/c8fyJ9bo++BrEC5xEYlpjfeTtB3NqAqRSj9g6EspRVv3G4c6Zi6/x gJQI3RJCUgj9Jm4EqFfhXiHVlDZPSG7EpfKm8HfjUIX3OQ56blVGnoFtQjKFCcah6k +8datetWtU1DVDo6+Jl7MzEnD7fMLuNvvforZMdg=
From: ianswett <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/1998/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] introduce a max_connection_ids transport parameter (#1998)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c1a558fe0221_40843fbdc14d45b83450d0"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Wed, 19 Dec 2018 14:28:35 -0000

ianswett commented on this pull request.

This LGTM, but we definitely need to resolve Mike's comment.

> @@ -3806,6 +3803,7 @@ language from Section 3 of {{!TLS13=RFC8446}}.
+      max_connection_ids(14),

I don't see a need to, personally.

> @@ -3981,6 +3979,12 @@ A client MUST NOT include an original connection ID, a stateless reset token, or
 a preferred address.  A server MUST treat receipt of any of these transport
 parameters as a connection error of type TRANSPORT_PARAMETER_ERROR.
+max_connection_ids (0x000e):
+: The maximum number of connection IDs that the peer is willing to store.
+  This value includes only connection IDs sent in NEW_CONNECTION_ID frames.

I think it makes sense to only apply this to NEW_CONNECTION_ID CIDs as Marten said.

SPA is a special case, since you have to use the new CID with the new address, I don't think I can treat that CID like other CIDS.

> @@ -4958,6 +4962,10 @@ INVALID_MIGRATION (0xC):
 : A peer has migrated to a different network when the endpoint had disabled
+: A peer received more connection IDs than its advertised limit.

I think your comment was lost, can you restate it here?

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: