[quicwg/base-drafts] Bikeshed Required Insert Count encoding. (#2366)

Bence Béky <notifications@github.com> Wed, 23 January 2019 16:27 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C8FA2130E97 for <quic-issues@ietfa.amsl.com>; Wed, 23 Jan 2019 08:27:10 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.573
X-Spam-Level:
X-Spam-Status: No, score=-6.573 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FROM_EXCESS_BASE64=0.979, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OEx76WlDeGWt for <quic-issues@ietfa.amsl.com>; Wed, 23 Jan 2019 08:27:09 -0800 (PST)
Received: from o1.sgmail.github.com (o1.sgmail.github.com [192.254.114.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0431B130E7D for <quic-issues@ietf.org>; Wed, 23 Jan 2019 08:27:08 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=1PEaOD59Zvfi5ATU2+c9Pr5zlqE=; b=OQ/KuMTm6Iw75cmq A9nWypPHMqdkgN14FVeKN5vxeC/NYmOIFaSrxST00YyUxMl7fjBTjM9htpp0kLaq X5xRxeCwb0WgjOlX3od7ISZ5WCL/cgrUQqMkm6rE/gJfMANu9GkW0OStgKcnBMu6 EzHjOB7hgu2CQNvBcMjZItKWQgc=
Received: by filter1606p1mdw1.sendgrid.net with SMTP id filter1606p1mdw1-3111-5C4895DC-3 2019-01-23 16:27:08.037503439 +0000 UTC m=+463823.358226156
Received: from github-lowworker-0b1e58d.cp1-iad.github.net (unknown [192.30.252.43]) by ismtpd0039p1iad1.sendgrid.net (SG) with ESMTP id XU3Cs3LIRH6hxnYSD2ui8Q for <quic-issues@ietf.org>; Wed, 23 Jan 2019 16:27:07.924 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-0b1e58d.cp1-iad.github.net (Postfix) with ESMTP id E0B353E0C60 for <quic-issues@ietf.org>; Wed, 23 Jan 2019 08:27:07 -0800 (PST)
Date: Wed, 23 Jan 2019 16:27:08 +0000
From: Bence Béky <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab0bb48b41e7563c64587ffcd03dd90c1af8913cea92cf00000001186057db92a169ce17faf23c@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2366@github.com>
Subject: [quicwg/base-drafts] Bikeshed Required Insert Count encoding. (#2366)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c4895dbdf093_2f2c3f8ef6cd45b4351559"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: bencebeky
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1M/CB4iI0dOzytL+aZkSuxFcO5Oo0xuL20sR mcOIm2vtFxo3C2by2aBPX13RSlmlnj6/GFf1LAE9XupM63lb2VaFMgKL2u5KqlWLbEvlpLPeNFYzxO iSAzfGzXkY8jRXBvUjcC/kCk+OANINtrz8mpUSyQ8itAPADsNR4/OgZq0m+f04ox/6Bj/uni9iUydT I=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/nvQakJYE5Q8AFcYZrRreQwQNKVw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Jan 2019 16:27:11 -0000

1. This makes the encoding and decoding pseudo-code more symmetric.
2. "Alternatively" might not be the best word here, because it might imply that the implementation has a choice.
3. In a section about encoding Required Insert Count, it is more pure to talk about Required Insert Count being zero than to talk about whether references are made to the dynamic table.
You can view, comment on, or merge this pull request online at:

  https://github.com/quicwg/base-drafts/pull/2366

-- Commit Summary --

  * Bikeshed Required Insert Count encoding.

-- File Changes --

    M draft-ietf-quic-qpack.md (9)

-- Patch Links --

https://github.com/quicwg/base-drafts/pull/2366.patch
https://github.com/quicwg/base-drafts/pull/2366.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2366