Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1])
 by ietfa.amsl.com (Postfix) with ESMTP id 188B31202BE
 for <quic-issues@ietfa.amsl.com>; Wed, 27 Mar 2019 01:59:58 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.455
X-Spam-Level: 
X-Spam-Status: No, score=-1.455 tagged_above=-999 required=5
 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_20=1.546,
 HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001,
 SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key)
 header.d=github.com
Received: from mail.ietf.org ([4.31.198.44])
 by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id yognp_Dhtwqb for <quic-issues@ietfa.amsl.com>;
 Wed, 27 Mar 2019 01:59:55 -0700 (PDT)
Received: from o6.sgmail.github.com (o6.sgmail.github.com [192.254.113.101])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by ietfa.amsl.com (Postfix) with ESMTPS id 8BAF4120458
 for <quic-issues@ietf.org>; Wed, 27 Mar 2019 01:59:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; 
 h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe;
 s=s20150108; bh=+z62JSiFXpvE8IcbIw6eTNPtIQ0=; b=rn6pFOxUn+/lcT+S
 mqwJ72iZGYmWLHUKIcsSqD0a6LMr/AdseHHguyFoShJR2r/E9e1sX50UQFfBRup9
 Smm4nusQugQnbKh/H5j8TpNQFwQfWjT84hvUfUSpWPZHHIzySPZZMI8jdUSLvN1D
 k8Lt9GIF80gWrXGEPNX6mszUaFc=
Received: by filter1467p1mdw1.sendgrid.net with SMTP id
 filter1467p1mdw1-32642-5C9B3B8A-10
 2019-03-27 08:59:54.572162618 +0000 UTC m=+941056.546394608
Received: from github-lowworker-97d0962.cp1-iad.github.net (unknown
 [192.30.252.41])
 by ismtpd0004p1iad1.sendgrid.net (SG) with ESMTP id UHDCHkRMRnWA3UhpxeeQIQ
 for <quic-issues@ietf.org>; Wed, 27 Mar 2019 08:59:54.525 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1])
 by github-lowworker-97d0962.cp1-iad.github.net (Postfix) with ESMTP id
 8157B80316
 for <quic-issues@ietf.org>; Wed, 27 Mar 2019 01:59:54 -0700 (PDT)
Date: Wed, 27 Mar 2019 08:59:54 +0000 (UTC)
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4ab861da3699fa2e4de3b6f8f6ebd503d26230a2e7092cf0000000118b2fd8a92a169ce1961a1eb@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2560/review/219333236@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2560@github.com>
References: <quicwg/base-drafts/pull/2560@github.com>
Subject: Re: [quicwg/base-drafts] Transport parameters are mandatory. Fixes
 #2528 (#2560)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5c9b3b8a7f6ba_27e63febca8d45b4477657";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3Hr0mWixmVEEdCrU09ByzkCdzroGcVyYN5JU
 Uqegmr8ucdFOi/FLRNyPM7CV/wMbVXF92/vEapWpMtVAl6NUGhcJUoaePlTzUNKNzBUMDJu7eQGOY0
 XZUCF8H41aN6q7xl37N0vFVoA1B08eiglm02T0vh8AldyXSnAHloU0GvHsg/xha5NDbT/1Ya2gBhUz
 U=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/nz6j_oSkhOf2QuF1Wd3dKtBPFQc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG
 <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Mar 2019 09:00:04 -0000

----==_mimepart_5c9b3b8a7f6ba_27e63febca8d45b4477657
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

martinthomson approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2560#pullrequestreview-219333236
----==_mimepart_5c9b3b8a7f6ba_27e63febca8d45b4477657
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@martinthomson</b> approved this pull request.</p>



<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/2560#pullrequestreview-219333236">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkq0oASnPcsU5Ezd2pnlnq7LGwftXuks5vazMKgaJpZM4cNO01">mute the thread</a>.<img src="https://github.com/notifications/beacon/AWbkq_dw87Vk82hIztqmOMcgfR-3zDJCks5vazMKgaJpZM4cNO01.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@martinthomson approved #2560"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/2560#pullrequestreview-219333236"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/2560#pullrequestreview-219333236",
"url": "https://github.com/quicwg/base-drafts/pull/2560#pullrequestreview-219333236",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5c9b3b8a7f6ba_27e63febca8d45b4477657--

