Re: [quicwg/base-drafts] Packet number echo (#351)
Brian Trammell <notifications@github.com> Thu, 02 March 2017 17:32 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8EE46129593 for <quic-issues@ietfa.amsl.com>; Thu, 2 Mar 2017 09:32:19 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -5.597
X-Spam-Level:
X-Spam-Status: No, score=-5.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qyPSOFk11jpP for <quic-issues@ietfa.amsl.com>; Thu, 2 Mar 2017 09:32:18 -0800 (PST)
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2-ext6.iad.github.net [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 11E1C129594 for <quic-issues@ietf.org>; Thu, 2 Mar 2017 09:32:18 -0800 (PST)
Date: Thu, 02 Mar 2017 09:32:17 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1488475937; bh=3uSSRzeYlniO1sNVWYo0IbnXaAarMJ+1FFZRIW3F39A=; h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=FR801Kh4DmLJUHe4edlb2Gnlzsi69DvUge2wR3DkMv4hxlUbFsbs7DKtuOCHEnbfp hkGJP9Wo+2gbtOOToU/KcSc9evdVyBZCS0/BHIXg4dMazeIwShh7moyD4Ece9bYjeK MBzXbNZff1cvrbgku3zLGNcKzAhI3ZZJ3YED6cPk=
From: Brian Trammell <notifications@github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/351/review/24793177@github.com>
In-Reply-To: <quicwg/base-drafts/pull/351@github.com>
References: <quicwg/base-drafts/pull/351@github.com>
Subject: Re: [quicwg/base-drafts] Packet number echo (#351)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_58b8572163608_2a913ffbd7495c3854915"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: britram
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/o0h8WmUT6QI7G4v3YNMC6iRXI1s>
Cc: Subscribed <subscribed@noreply.github.com>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.17
Reply-To: quic@ietf.org
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Mar 2017 17:32:19 -0000
britram commented on this pull request. > @@ -470,7 +472,9 @@ this version, it contains: * 01: 1-RTT packet (packet number size = 1) * 02: 1-RTT packet (packet number size = 2) * 03: 1-RTT packet (packet number size = 4) + * 07: 1-RTT packet (packet number size = 4, with packet number echo) Can add two additional codepoints here: ``` * 05: 1-RTT packet (packet number size = 1, packet number echo size = 1) * 06: 1-RTT packet (packet number size = 2, packet number echo size = 2) ``` (I remain skeptical of the tradeoff for varlen packet numbers, but if we're going to have them, we might as well have varlen echo as well.) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/351#pullrequestreview-24793177
- [quicwg/base-drafts] Packet number echo (#351) Brian Trammell
- Re: [quicwg/base-drafts] Packet number echo (#351) Brian Trammell
- Re: [quicwg/base-drafts] Packet number echo (#351) ianswett
- Re: [quicwg/base-drafts] Packet number echo (#351) Brian Trammell
- Re: [quicwg/base-drafts] Packet number echo (#351) Brian Trammell
- Re: [quicwg/base-drafts] Packet number echo (#351) Martin Thomson
- Re: [quicwg/base-drafts] Packet number echo (#351) Brian Trammell
- Re: [quicwg/base-drafts] Packet number echo (#351) Brian Trammell
- Re: [quicwg/base-drafts] Packet number echo (#351) Brian Trammell