Re: [quicwg/base-drafts] Clarify that unlinkability is required for NEW_TOKEN tokens. Changes … (#2647)

Jana Iyengar <notifications@github.com> Mon, 06 May 2019 23:43 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A75AF12006B for <quic-issues@ietfa.amsl.com>; Mon, 6 May 2019 16:43:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.464
X-Spam-Level:
X-Spam-Status: No, score=-6.464 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CrGd1lDwdAqX for <quic-issues@ietfa.amsl.com>; Mon, 6 May 2019 16:43:51 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7A4D612001E for <quic-issues@ietf.org>; Mon, 6 May 2019 16:43:51 -0700 (PDT)
Date: Mon, 06 May 2019 16:43:50 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1557186230; bh=Mq9aU5MweVUk96gbCz1QCX/jLzNAf8RYban0j2I1I44=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=EVHVknbuKWSnc+CFoFSiKnFGUuuglQKgd93U7B06+6KA6BS3gzQ1bPgLhe4DhJnfg Tw89/bzKRAV0B63F8mx3OFg2p8B41iP656NmbVYePiOckKqv0gCrnjmwxBtcQSbqAc 8bhVl+cI8E6hm99OYIEE8AseCVR23t7712iVw7PU=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4YVD4GZA4MURDQ2GN23X4TNEVBNHHBUBA3UE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2647/review/234250696@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2647@github.com>
References: <quicwg/base-drafts/pull/2647@github.com>
Subject: =?UTF-8?Q?Re:_[quicwg/base-drafts]_Clarify_that_unlinkability_is?= =?UTF-8?Q?_required_for_NEW=5FTOKEN_tokens._Changes_=E2=80=A6_=28#2647=29?=
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cd0c6b65f0b6_6c313f9d408cd968160026"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/o2Fh47JjUQ8nJrr8owpSIVdLTIY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 06 May 2019 23:43:54 -0000

janaiyengar commented on this pull request.

Looks good, modulo the minor suggestions.

>  A token SHOULD be constructed for the server to easily distinguish it from
 tokens that are sent in Retry packets as they are carried in the same field.
+The token SHOULD NOT expose linkability; i.e., information that lets observers

+1, but slight grammar: "The token MUST NOT include information that would allow it to be linked by an on-path observer to the connection on which it was issued."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2647#pullrequestreview-234250696