Re: [quicwg/base-drafts] Deadlocks, and how to avoid them (#3458)

ianswett <notifications@github.com> Fri, 14 February 2020 17:49 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 99CEF12091C for <quic-issues@ietfa.amsl.com>; Fri, 14 Feb 2020 09:49:31 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.597
X-Spam-Level:
X-Spam-Status: No, score=-6.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0rFBLI0UwYdU for <quic-issues@ietfa.amsl.com>; Fri, 14 Feb 2020 09:49:29 -0800 (PST)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4F4D112080F for <quic-issues@ietf.org>; Fri, 14 Feb 2020 09:49:29 -0800 (PST)
Date: Fri, 14 Feb 2020 09:49:28 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1581702568; bh=I5p9B2Z9JmXDDK9GvmXOZ7SJBwQx0nG/5NxfwjTbnU4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=HyCCd5+icGWaRdwXV1OIeuahr0I3k/M4MGBwDM5v04zbz+XOeTQZC3jM+AWKdAtMv Uqb4Ovad3KAkf0DKu1NBVEkJXKTdGYW8xALlp8HlidvhYdjC1QtDzN1nF9BMbWrup1 813XmzKWt7zEVb/WurclQKP9g+H3bJE3B/gIu8EE=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK22AVQWXUKZ3FD6OVV4KQICREVBNHHCDLNOLI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3458/review/359109199@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3458@github.com>
References: <quicwg/base-drafts/pull/3458@github.com>
Subject: Re: [quicwg/base-drafts] Deadlocks, and how to avoid them (#3458)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e46dda816330_10473fdbb62cd964698e2"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/oGdYAaGQaZ3qfrEIKshanALBBS8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Feb 2020 17:49:32 -0000

ianswett commented on this pull request.

Thanks for adding this!

> @@ -281,6 +281,26 @@ table entries which have been acknowledged, but this could mean using
 literals. Since literals make the header block larger, this can result in the
 encoder becoming blocked on congestion or flow control limits.
 
+### Avoiding Flow Control Deadlocks
+
+Encoding using blocked streams can interact with flow control to produce

```suggestion
Writing instructions on blocked or soon to be blocked streams can interact with flow control to produce
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3458#pullrequestreview-359109199