Re: [quicwg/base-drafts] lost_pn can no longer be negative (#2621)

ianswett <notifications@github.com> Mon, 15 April 2019 15:46 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4270F12012B for <quic-issues@ietfa.amsl.com>; Mon, 15 Apr 2019 08:46:54 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.597
X-Spam-Level:
X-Spam-Status: No, score=-6.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zIIAChyOFOip for <quic-issues@ietfa.amsl.com>; Mon, 15 Apr 2019 08:46:52 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 446D512004D for <quic-issues@ietf.org>; Mon, 15 Apr 2019 08:46:52 -0700 (PDT)
Date: Mon, 15 Apr 2019 08:46:51 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1555343211; bh=tQ59znmHQ5eW8YxfWcowL/kuUFHeWCjCICYHaEmsFLs=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=WoZnaaniIOHdoz/9fgIkSE0BH/BcV73dCaUAVy3VFcrLgvQM0woQX5oISmyjoXy2y fYdW+DGpDCJVBVMcJ8z6aWJAGlKcWCk9entrj8/BpRjfqbDw302dbnMCPrl+2gBXBy czEnZ2+L7hi9dnDnIY7j2SaQR7mHxD9ukfc5H0qA=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abd6e9b34094195290550394d917c1b1e3d0b9d16592cebac1d9eb92a169ce19d467b3@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2621/c483308056@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2621@github.com>
References: <quicwg/base-drafts/pull/2621@github.com>
Subject: Re: [quicwg/base-drafts] lost_pn can no longer be negative (#2621)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cb4a76b4f72f_19d73fcb4e2d45c07393f"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/oIVtCkVMxYTntOm00rbqZdoeCHs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Apr 2019 15:46:54 -0000

I prefer to initialize to -1, but previously some people were really opposed to allowing packet numbers and other variables in this pseudocode be signed.

If variables are signed, then we don't really need to do anything here, but it would be more correct to initialize largest_acked_packet[pn_space] to -1.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2621#issuecomment-483308056