Re: [quicwg/base-drafts] Second set of editorial nits (#3770)

Jana Iyengar <notifications@github.com> Thu, 18 June 2020 22:08 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A4F9E3A1022 for <quic-issues@ietfa.amsl.com>; Thu, 18 Jun 2020 15:08:18 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.697
X-Spam-Level:
X-Spam-Status: No, score=-1.697 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pPX2dXONF-_V for <quic-issues@ietfa.amsl.com>; Thu, 18 Jun 2020 15:08:17 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 489B13A1021 for <quic-issues@ietf.org>; Thu, 18 Jun 2020 15:08:17 -0700 (PDT)
Received: from github-lowworker-52827f8.ash1-iad.github.net (github-lowworker-52827f8.ash1-iad.github.net [10.56.108.24]) by smtp.github.com (Postfix) with ESMTP id BF5D98C0328 for <quic-issues@ietf.org>; Thu, 18 Jun 2020 15:08:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1592518095; bh=elIpMxmY2XiHqBZnrjf6VjTQtki7Jg3faguNrL8MXRQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=nbKu2W4CLlu6blSEhh/Yr2FCj3Sn+CF+tyW3OuGBua5TUf2S6yng/ypChbH+tYWZR 5KMWOt9AASxrjuHMq2ctkdHRtYRY/RTpE13cpmycpWrPQNR0868hvZPIQFd7RNhimi /zdsWiD36X5QPjafRCUCUdnfV1wvBHarJwL/946M=
Date: Thu, 18 Jun 2020 15:08:15 -0700
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7ODNW3V2K7UULHBK5467DM7EVBNHHCMKRPF4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3770/review/433676406@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3770@github.com>
References: <quicwg/base-drafts/pull/3770@github.com>
Subject: Re: [quicwg/base-drafts] Second set of editorial nits (#3770)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5eebe5cfaf633_636c3fe14d6cd964162553"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/oU6oqYPw4pFxGh3tUFrdACqeZxQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Jun 2020 22:08:19 -0000

@janaiyengar approved this pull request.

Let's get these in and deal with more specific issues separately.

> @@ -3463,9 +3464,10 @@ the IP header SHOULD be acknowledged immediately, to reduce the peer's response
 time to congestion events.
 
 The algorithms in {{QUIC-RECOVERY}} are expected to be resilient to receivers
-that do not follow guidance offered above. However, an implementer should only
+that do not follow guidance offered above. However, an endpoint should only

```suggestion
that do not follow guidance offered above. However, an implementation should only
```

>  necessary if an ACK frame would be too large to fit in a packet, however
 receivers MAY also limit ACK frame size further to preserve space for other

```suggestion
necessary if an ACK frame would be too large to fit in a packet.
Receivers MAY also limit ACK frame size further to preserve space for other
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3770#pullrequestreview-433676406