Re: [quicwg/base-drafts] Largest acked in ACK frame MUST NOT decrease (#2205)

Magnus Westerlund <notifications@github.com> Tue, 08 January 2019 10:40 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 161FF130E94 for <quic-issues@ietfa.amsl.com>; Tue, 8 Jan 2019 02:40:43 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.065
X-Spam-Level:
X-Spam-Status: No, score=-8.065 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id E5qrC0oYTYTH for <quic-issues@ietfa.amsl.com>; Tue, 8 Jan 2019 02:40:41 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 55434127133 for <quic-issues@ietf.org>; Tue, 8 Jan 2019 02:40:41 -0800 (PST)
Date: Tue, 08 Jan 2019 02:40:40 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1546944040; bh=fxAj/rdHGBLEo/SicEslCu6PdKhdicHlfVi3r0WWo+U=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=SqGIcBQWZAAYPFNjA1WXvNxrHBZSeh/NiJfcGDxLva3X5uIDoDEAPGCQFVTosph/P Cg/oPPSVcpiQLLoMN6FG5ja5DqdkqZsPQiZMrVhW0LRfPb0Y/d800NKjwpUddzp0Ii 6ermrFmJPbMPbJKsXG+tvteXamyiV6K1ZE2alaE4=
From: Magnus Westerlund <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abedec90e30511fae6d8bc1bd28a5053c2dd84c2e292cf00000001184c402892a169ce1762ed93@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2205/452253504@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2205@github.com>
References: <quicwg/base-drafts/issues/2205@github.com>
Subject: Re: [quicwg/base-drafts] Largest acked in ACK frame MUST NOT decrease (#2205)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c347e2822de4_3d133f8aa4ad45bc2789b2"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: gloinul
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/oY-ypH5x7n7MfkvJtJ01E1FiUH0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Jan 2019 10:40:43 -0000

My concern was primarily about the clearness of this behavior in the specification text. In transport I find the following which indicates this but are not explicit. 

13.1.1:    To limit receiver state or the size of ACK frames, a receiver MAY
   limit the number of ACK Ranges it sends.

19.3:

  Largest Acknowledged:  A variable-length integer representing the
      largest packet number the peer is acknowledging; this is usually
      the largest packet number that the peer has received prior to
      generating the ACK frame. 

I think there are strong hints, with the above "usually the largest" indicating that it is not always. I would have made this explicit in 19.3, but then I prefer being more explicit than not. I think it is possible interop issue point. Anywhere else this is more explicit? (I have read github master version)

@mikkelfj I think there are strong points for allowing an ACK frame to acknowledge only a part of the range between highest received and confirmed to be have been ACKed. The two main reasons I see.
- high rate flows suffering an packet loss burst so that the number of ACK ranges becomes to large to fit a single QUIC packet. 
- Low complexity receivers ACKing a single range of received packets and doing this for reordered packets.
 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2205#issuecomment-452253504