Re: [quicwg/base-drafts] CONNECTION_CLOSE is non-ack-eliciting (#3098)

[Martin Thomson <[e-mail]>]

martinthomson approved this pull request.

Seems right to me.  Editorial tweaks suggested.

> @@ -123,7 +123,8 @@ In-flight:
 
 Ack-eliciting Frames:
 
-: All frames besides ACK or PADDING are considered ack-eliciting.
+: All frames besides ACK, PADDING, or CONNECTION_CLOSE are considered

```suggestion
: All frames other than ACK, PADDING, and CONNECTION_CLOSE are considered
```

> @@ -2992,9 +2993,8 @@ valid frames? -->
 ## Generating Acknowledgements {#generating-acks}
 
 Endpoints acknowledge all packets they receive and process. However, only
-ack-eliciting packets (see {{QUIC-RECOVERY}}) trigger the sending of an ACK
-frame.  Packets that are not ack-eliciting are only acknowledged when an ACK
-frame is sent for other reasons.
+ack-eliciting packets trigger the sending of an ACK frame.  Packets that are not

Can we fix this here?  I know that this isn't this PR, but I would prefer to say:

```suggestion
ack-eliciting packets cause an ACK frame to be sent within the maximum ack delay.  Packets that are not
```

Or something like that.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3098#pullrequestreview-304920319