Date: Mon, 21 Oct 2019 17:28:25 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJKYDCVSBURXMU75AW4V3XN72TEVBNHHB4RTQYY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3098/review/304920319@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3098@github.com>
References: <quicwg/base-drafts/pull/3098@github.com>
Subject: Re: [quicwg/base-drafts] CONNECTION_CLOSE is non-ack-eliciting (#3098)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5dae4d296fcb6_54e63fef7e8cd96488379";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/oZOfW90kDLfW0j-Y7yh26iy7zoI>


----==_mimepart_5dae4d296fcb6_54e63fef7e8cd96488379
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

martinthomson approved this pull request.

Seems right to me.  Editorial tweaks suggested.

> @@ -123,7 +123,8 @@ In-flight:
 
 Ack-eliciting Frames:
 
-: All frames besides ACK or PADDING are considered ack-eliciting.
+: All frames besides ACK, PADDING, or CONNECTION_CLOSE are considered

```suggestion
: All frames other than ACK, PADDING, and CONNECTION_CLOSE are considered
```

> @@ -2992,9 +2993,8 @@ valid frames? -->
 ## Generating Acknowledgements {#generating-acks}
 
 Endpoints acknowledge all packets they receive and process. However, only
-ack-eliciting packets (see {{QUIC-RECOVERY}}) trigger the sending of an ACK
-frame.  Packets that are not ack-eliciting are only acknowledged when an ACK
-frame is sent for other reasons.
+ack-eliciting packets trigger the sending of an ACK frame.  Packets that are not

Can we fix this here?  I know that this isn't this PR, but I would prefer to say:

```suggestion
ack-eliciting packets cause an ACK frame to be sent within the maximum ack delay.  Packets that are not
```

Or something like that.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3098#pullrequestreview-304920319
----==_mimepart_5dae4d296fcb6_54e63fef7e8cd96488379
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<p><b>@martinthomson</b> approved this pull request.</p>=0D
=0D
<p>Seems right to me.  Editorial tweaks suggested.</p><hr>=0D
=0D
<p>In <a href=3D"https://github.com/quicwg/base-drafts/pull/3098#discussi=
on_r337295500">draft-ietf-quic-recovery.md</a>:</p>=0D
<pre style=3D'color:#555'>&gt; @@ -123,7 +123,8 @@ In-flight:=0D
 =0D
 Ack-eliciting Frames:=0D
 =0D
-: All frames besides ACK or PADDING are considered ack-eliciting.=0D
+: All frames besides ACK, PADDING, or CONNECTION_CLOSE are considered=0D=

</pre>=0D
=E2=AC=87=EF=B8=8F Suggested change=0D
<pre style=3D"color: #555">-: All frames besides ACK, PADDING, or CONNECT=
ION_CLOSE are considered=0D
+: All frames other than ACK, PADDING, and CONNECTION_CLOSE are considere=
d=0D
</pre>=0D
=0D
=0D
<hr>=0D
=0D
<p>In <a href=3D"https://github.com/quicwg/base-drafts/pull/3098#discussi=
on_r337296047">draft-ietf-quic-transport.md</a>:</p>=0D
<pre style=3D'color:#555'>&gt; @@ -2992,9 +2993,8 @@ valid frames? --&gt;=
=0D
 ## Generating Acknowledgements {#generating-acks}=0D
 =0D
 Endpoints acknowledge all packets they receive and process. However, onl=
y=0D
-ack-eliciting packets (see {{QUIC-RECOVERY}}) trigger the sending of an =
ACK=0D
-frame.  Packets that are not ack-eliciting are only acknowledged when an=
 ACK=0D
-frame is sent for other reasons.=0D
+ack-eliciting packets trigger the sending of an ACK frame.  Packets that=
 are not=0D
</pre>=0D
<p>Can we fix this here?  I know that this isn't this PR, but I would pre=
fer to say:</p>=0D
=E2=AC=87=EF=B8=8F Suggested change=0D
<pre style=3D"color: #555">-ack-eliciting packets trigger the sending of =
an ACK frame.  Packets that are not=0D
+ack-eliciting packets cause an ACK frame to be sent within the maximum a=
ck delay.  Packets that are not=0D
</pre>=0D
=0D
<p>Or something like that.</p>=0D
=0D
<p style=3D"font-size:small;-webkit-text-size-adjust:none;color:#666;">&m=
dash;<br />You are receiving this because you are subscribed to this thre=
ad.<br />Reply to this email directly, <a href=3D"https://github.com/quic=
wg/base-drafts/pull/3098?email_source=3Dnotifications&amp;email_token=3DA=
FTOJK6T3B4L4Z5TMPBNS6LQPZCKTA5CNFSM4JBNK722YY3PNVWWK3TUL52HS4DFWFIHK3DMKJ=
SXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCIWLN7Y#pullrequestreview-304920319=
">view it on GitHub</a>, or <a href=3D"https://github.com/notifications/u=
nsubscribe-auth/AFTOJK5UQJPK2XXZGXLF4JTQPZCKTANCNFSM4JBNK72Q">unsubscribe=
</a>.<img src=3D"https://github.com/notifications/beacon/AFTOJK4CKLNO7QIY=
RYCAIVTQPZCKTA5CNFSM4JBNK722YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWN=
FSXPKTDN5WW2ZLOORPWSZGOCIWLN7Y.gif" height=3D"1" width=3D"1" alt=3D"" /><=
/p>=0D
<script type=3D"application/ld+json">[=0D
{=0D
"@context": "http://schema.org",=0D
"@type": "EmailMessage",=0D
"potentialAction": {=0D
"@type": "ViewAction",=0D
"target": "https://github.com/quicwg/base-drafts/pull/3098?email_source=3D=
notifications\u0026email_token=3DAFTOJK6T3B4L4Z5TMPBNS6LQPZCKTA5CNFSM4JBN=
K722YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOC=
IWLN7Y#pullrequestreview-304920319",=0D
"url": "https://github.com/quicwg/base-drafts/pull/3098?email_source=3Dno=
tifications\u0026email_token=3DAFTOJK6T3B4L4Z5TMPBNS6LQPZCKTA5CNFSM4JBNK7=
22YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCIW=
LN7Y#pullrequestreview-304920319",=0D
"name": "View Pull Request"=0D
},=0D
"description": "View this Pull Request on GitHub",=0D
"publisher": {=0D
"@type": "Organization",=0D
"name": "GitHub",=0D
"url": "https://github.com"=0D
}=0D
}=0D
]</script>=

----==_mimepart_5dae4d296fcb6_54e63fef7e8cd96488379--