Re: [quicwg/base-drafts] Don't amplify 0-RTT (#1616)

Martin Thomson <notifications@github.com> Thu, 02 August 2018 00:43 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AB421130E88 for <quic-issues@ietfa.amsl.com>; Wed, 1 Aug 2018 17:43:42 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gqNdN1oS2N2j for <quic-issues@ietfa.amsl.com>; Wed, 1 Aug 2018 17:43:39 -0700 (PDT)
Received: from out-15.smtp.github.com (out-15.smtp.github.com [192.30.254.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 21FD2130E93 for <quic-issues@ietf.org>; Wed, 1 Aug 2018 17:43:39 -0700 (PDT)
Date: Wed, 01 Aug 2018 17:43:38 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1533170618; bh=Q3F1W5iowcggEMTYXYiyNNaCrDYMtpp55liVurY1p+g=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Tayfjuk0Sg/pJAFUQQ3wjrWbi8J9ROO9zyPYw1/e8BIaOacNL3sgRrvRSuCSlptQ+ ojxtlxW/8fH125bQZHTiE63CswJdcPKnidU+YjGcKGhD+4Sg/0ZfRzOWFElLzVlR5X VwqaxVVXBNIpCPoNethuAzvhIgB+pV1MnwE0sGPg=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abc64fb747bb51852399b88c8aeb993524bfea02af92cf00000001177a15ba92a169ce14a01a2f@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1616/review/142611861@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1616@github.com>
References: <quicwg/base-drafts/pull/1616@github.com>
Subject: Re: [quicwg/base-drafts] Don't amplify 0-RTT (#1616)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b6253ba7d03e_d9853fc8306be62028925b"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/oaOxvtvrtJQc24H0cmwPxZZMblA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Aug 2018 00:43:43 -0000

martinthomson commented on this pull request.



> @@ -1896,6 +1896,13 @@ dynamically calculate the expiration time.  It is also unlikely that the client
 port number is the same on two different connections; validating the port is
 therefore unlikely to be successful.
 
+Even when a token is valid, a server SHOULD limit the amount of data that it
+sends toward a client in response to 0-RTT data.  Spoofing of source addresses
+and replays of 0-RTT handshake messages can cause tokens to appear to be valid
+when they are not.  No specific recommendation is made regarding the ratio of
+data sent to received, though it is unlikely to be necessary to send more than
+the initial congestion window.

Yeah, this is why it is worded so loosely.  Without this advice, the risk seems to be limited to the server receiving a spoofed ACK for the ServerHello and sending that much more in response, but that's only one more packet than the IW, so it's hardly earth-shattering.

Given that this is largely dictated by congestion controller design (IW specifically), is this really a change we need to implement?  Should we instead close #1309 with no change?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1616#discussion_r207073216