From nobody Sat Mar 21 12:15:29 2020 Return-Path: X-Original-To: quic-issues@ietfa.amsl.com Delivered-To: quic-issues@ietfa.amsl.com Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9B0D43A08EB for ; Sat, 21 Mar 2020 12:13:50 -0700 (PDT) X-Virus-Scanned: amavisd-new at amsl.com X-Spam-Flag: NO X-Spam-Score: -1.685 X-Spam-Level: X-Spam-Status: No, score=-1.685 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01] autolearn=unavailable autolearn_force=no Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id A2yl7ufNhqhh for ; Sat, 21 Mar 2020 12:12:21 -0700 (PDT) Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D564C3A08EF for ; Sat, 21 Mar 2020 12:11:31 -0700 (PDT) Date: Sat, 21 Mar 2020 12:11:27 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1584817887; bh=YS/55kAn7/62UGK97+jdMR8iDfVub+0+IFa9/HJ4wmQ=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ZGaIgBEWQhUM3p1+UG2hpffUJ11rUxWIQoHTg1CB8WiCDVjeJne1BHEwW0C7Kg4+8 rs3vNDs3ENs4k//57eIEfK+QvJGX+bpSuFl1BiKQAHMAqA1rDXBZ0QgIPtmZoS/Gdw cP/+t0rlh3COiAKy7cbkYziD3md0RJu6L70N1ymQ= From: ianswett Reply-To: quicwg/base-drafts To: quicwg/base-drafts Cc: Subscribed Message-ID: In-Reply-To: References: Subject: Re: [quicwg/base-drafts] eliminate the difference between when having no RTT sample and having one (#3525) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5e7666df3f23f_5cff3fbfb6ccd96c21309b"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: ianswett X-GitHub-Recipient: quic-issues X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: quic-issues@ietf.org Archived-At: X-BeenThere: quic-issues@ietf.org X-Mailman-Version: 2.1.29 List-Id: Notification list for GitHub issues related to the QUIC WG List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Mar 2020 19:14:15 -0000 X-List-Received-Date: Sat, 21 Mar 2020 19:14:15 -0000 ----==_mimepart_5e7666df3f23f_5cff3fbfb6ccd96c21309b Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ianswett approved this pull request. I think Jana's suggestions LGTM. > +smoothed_rtt and rttvar are computed as follows, similar to {{?RFC6298}}. When +there are no samples for a network path: I think @janaiyengar suggestion seems good and slightly clearer than before, though maybe line 361("where rtt_sample is the initial RTT." needs to be updated too? > @@ -517,12 +521,11 @@ data. ### Handshakes and New Paths -The initial probe timeout for a new connection or new path SHOULD be -set to twice the initial RTT. Resumed connections over the same network -SHOULD use the previous connection's final smoothed RTT value as the resumed -connection's initial RTT. If no previous RTT is available, the initial RTT -SHOULD be set to 500ms, resulting in a 1 second initial timeout as recommended -in {{?RFC6298}}. +Resumed nit: reflow the text -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3525#pullrequestreview-378943350 ----==_mimepart_5e7666df3f23f_5cff3fbfb6ccd96c21309b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

@ianswett approved this pull request.

I think Jana's suggestions LGTM.

In draft-ietf-quic-recovery.md:

> +smoothed_rtt and rttvar are computed as follows, similar to {{?RFC6298}}.  When
+there are no samples for a network path:

I think @janaiyengar suggestion seems good and slightly clearer than before, though maybe line 361("where rtt_sample is the initial RTT." needs to be updated too?

In draft-ietf-quic-recovery.md:

> @@ -517,12 +521,11 @@ data.
 
 ### Handshakes and New Paths
 
-The initial probe timeout for a new connection or new path SHOULD be
-set to twice the initial RTT.  Resumed connections over the same network
-SHOULD use the previous connection's final smoothed RTT value as the resumed
-connection's initial RTT.  If no previous RTT is available, the initial RTT
-SHOULD be set to 500ms, resulting in a 1 second initial timeout as recommended
-in {{?RFC6298}}.
+Resumed

nit: reflow the text

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

----==_mimepart_5e7666df3f23f_5cff3fbfb6ccd96c21309b--