IETF Logo Mail Archive

Re: [quicwg/base-drafts] define compound packets (#1262)

Martin Thomson <notifications@github.com> Tue, 10 April 2018 05:49 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A164B12D94D for <quic-issues@ietfa.amsl.com>; Mon, 9 Apr 2018 22:49:51 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.605
X-Spam-Level:
X-Spam-Status: No, score=-6.605 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lC3P-Sl0aiXT for <quic-issues@ietfa.amsl.com>; Mon, 9 Apr 2018 22:49:49 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C9FBC12D95D for <quic-issues@ietf.org>; Mon, 9 Apr 2018 22:49:49 -0700 (PDT)
Date: Mon, 09 Apr 2018 22:49:49 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1523339389; bh=OEKn+GZpcsIk9HzdNDcg6+D3uzI7l8LNQALxtOTTsdo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=JIxEwMYOEgOqrMrqypJ3ApWX+OgCksFz6OuCA2WLBmwr5/uPp1AN4ZrLWqfIG+8MZ +21L7AKpTrIN6x3qWJDQsw/FIXqc5JtYSKaUkA9UV9pmqZzBK185GKZBiuOGMJXNRM L5fuizjc29WCcIrcxZ2l0OlW4G1efndJFeuidNIc=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab8a11b6e50bb7bd649c35443292f7a6dee055a6b092cf0000000116e4127d92a169ce128c773a@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1262/review/110699397@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1262@github.com>
References: <quicwg/base-drafts/pull/1262@github.com>
Subject: Re: [quicwg/base-drafts] define compound packets (#1262)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5acc507d30c41_62bb3f921998ef2820096a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/og3LkY-75gQGn6C99E4t3Ry7Zgo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Apr 2018 05:49:52 -0000

martinthomson commented on this pull request.



> @@ -552,7 +552,7 @@ older than 1.3 is negotiated.
 
 QUIC requires that the initial handshake packet from a client fit within the
 payload of a single packet.  The size limits on QUIC packets mean that a record
-containing a ClientHello needs to fit within 1171 octets.
+containing a ClientHello needs to fit within 1170 octets.

If the packet is this big, then the length will be 2 octets.  You can't have encode 1170 (or 1169) in one octet.  Obviously, if the ClientHello is smaller, then the length might only be 1 octet, but I think that one octet is impossible.  ClientHello.random is 32 octets and either a shares is at least 32 octets or a PSK binder is that big too.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1262#discussion_r180303098

v2.46.0 | Report a Bug | By Email | System Status