Re: [quicwg/base-drafts] enforce the active_connection_id_limit (#3201)
Eric Kinnear <notifications@github.com> Mon, 18 November 2019 09:33 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E878B120892 for <quic-issues@ietfa.amsl.com>; Mon, 18 Nov 2019 01:33:03 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZU9roI19LEc5 for <quic-issues@ietfa.amsl.com>; Mon, 18 Nov 2019 01:33:02 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 32DBF12086D for <quic-issues@ietf.org>; Mon, 18 Nov 2019 01:33:02 -0800 (PST)
Date: Mon, 18 Nov 2019 01:33:01 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1574069581; bh=psFAHRL4Cjz3O/FMMjWIxB3mmfYuXv1qwKD8P3yQcJA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Y+jUICtDITSVAbo3uroljmYru+3meZUsUhW1uIynQBWxBc1tQNZu5VEDAPgX5jYGm fnQTmbkuoA+99/VxOLC5M0hBrrBvOZ3KvYRS08zyx6phy4CQ9eWrJdf9U66Ktz63J7 ILUAJcYay2A6apxQOzEheZeBH6lPml03nuxVTlFg=
From: Eric Kinnear <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6QSSSEP4GSVQRL7VN336L43EVBNHHB532IFY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3201/review/318195169@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3201@github.com>
References: <quicwg/base-drafts/pull/3201@github.com>
Subject: Re: [quicwg/base-drafts] enforce the active_connection_id_limit (#3201)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dd2654d3d3f7_1ad83fb0354cd9641253be"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: erickinnear
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/oiOIfdqi2V-MyqZdRDlc5lWGRoQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Nov 2019 09:33:04 -0000
erickinnear commented on this pull request. > @@ -999,8 +999,10 @@ retired are considered active; any active connection ID can be used. An endpoint SHOULD ensure that its peer has a sufficient number of available and unused connection IDs. Endpoints store received connection IDs for future use and advertise the number of connection IDs they are willing to store with the -active_connection_id_limit transport parameter. An endpoint SHOULD NOT provide -more connection IDs than the peer's limit. +active_connection_id_limit transport parameter. An endpoint MUST NOT provide +more connection IDs than the peer's limit. An endpoint that receives more +connection IDs than its advertised active_connection_id_limit MUST close the +connection with an error of type CONNECTION_ID_LIMIT_ERROR. I'm not sure that I'm against the SHOULD, but I think the idea behind enforcing this was that an endpoint would indeed now need to store every CID it receives, and if it's not willing to store X amount, then it shouldn't have advertised a limit of X. And even if you *still* didn't store them all, you technically don't need to store them to keep track of how many you've been issued, which you'll probably need in order to cope with getting Retire Prior To anyways. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3201#discussion_r347274181
- [quicwg/base-drafts] enforce the active_connectio… Marten Seemann
- Re: [quicwg/base-drafts] enforce the active_conne… ianswett
- Re: [quicwg/base-drafts] enforce the active_conne… Mike Bishop
- Re: [quicwg/base-drafts] enforce the active_conne… Eric Kinnear
- Re: [quicwg/base-drafts] enforce the active_conne… Marten Seemann
- Re: [quicwg/base-drafts] enforce the active_conne… Marten Seemann
- Re: [quicwg/base-drafts] enforce the active_conne… Marten Seemann
- Re: [quicwg/base-drafts] enforce the active_conne… Mike Bishop
- Re: [quicwg/base-drafts] enforce the active_conne… Marten Seemann
- Re: [quicwg/base-drafts] enforce the active_conne… Kazuho Oku
- Re: [quicwg/base-drafts] enforce the active_conne… Marten Seemann
- Re: [quicwg/base-drafts] enforce the active_conne… Marten Seemann
- Re: [quicwg/base-drafts] enforce the active_conne… Marten Seemann
- Re: [quicwg/base-drafts] enforce the active_conne… Eric Kinnear
- Re: [quicwg/base-drafts] enforce the active_conne… Marten Seemann
- Re: [quicwg/base-drafts] enforce the active_conne… Kazuho Oku
- Re: [quicwg/base-drafts] enforce the active_conne… Marten Seemann
- Re: [quicwg/base-drafts] enforce the active_conne… Marten Seemann
- Re: [quicwg/base-drafts] enforce the active_conne… Jana Iyengar
- Re: [quicwg/base-drafts] enforce the active_conne… Kazuho Oku
- Re: [quicwg/base-drafts] enforce the active_conne… Eric Kinnear
- Re: [quicwg/base-drafts] enforce the active_conne… Kazuho Oku
- Re: [quicwg/base-drafts] enforce the active_conne… Jana Iyengar
- Re: [quicwg/base-drafts] enforce the active_conne… Marten Seemann
- Re: [quicwg/base-drafts] enforce the active_conne… Marten Seemann
- Re: [quicwg/base-drafts] enforce the active_conne… Kazuho Oku
- Re: [quicwg/base-drafts] enforce the active_conne… Eric Kinnear
- Re: [quicwg/base-drafts] enforce the active_conne… Jana Iyengar
- Re: [quicwg/base-drafts] enforce the active_conne… Christian Huitema
- Re: [quicwg/base-drafts] enforce the active_conne… Marten Seemann
- Re: [quicwg/base-drafts] enforce the active_conne… Marten Seemann
- Re: [quicwg/base-drafts] enforce the active_conne… Marten Seemann
- Re: [quicwg/base-drafts] enforce the active_conne… Marten Seemann
- Re: [quicwg/base-drafts] enforce the active_conne… Martin Thomson
- Re: [quicwg/base-drafts] enforce the active_conne… Christian Huitema
- Re: [quicwg/base-drafts] enforce the active_conne… Marten Seemann
- Re: [quicwg/base-drafts] enforce the active_conne… Martin Thomson