IETF Logo Mail Archive

Re: [quicwg/base-drafts] lost_pn can no longer be negative (#2621)

Jana Iyengar <notifications@github.com> Mon, 15 April 2019 23:56 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C6EF4120198 for <quic-issues@ietfa.amsl.com>; Mon, 15 Apr 2019 16:56:30 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ciEgYFGXgGpH for <quic-issues@ietfa.amsl.com>; Mon, 15 Apr 2019 16:56:29 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 066E712009A for <quic-issues@ietf.org>; Mon, 15 Apr 2019 16:56:29 -0700 (PDT)
Date: Mon, 15 Apr 2019 16:56:28 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1555372588; bh=LAEFXP492Onc2iBGCWx84NkPsnTHXi5/8WI81Nv7gx0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=urhwBZvTzgu00fHATGSSn036Mmc2UKEUJ93kNxX/yeDIAhFPRvEYrgG+zFsJL3Mq3 Tde3cvi359xbQ8BpEmOMYpowuUN6Gb8df3rTo+wHhuV/DOJ4R4B4A5yZznPqSeWZS8 FL8HlaTldspNmWHuXAeKeWGyoNLO10YaPRh2YipM=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab1cf8948a3ccdee291f426e112820bb04ee78f71192cebac24cac92a169ce19d467b3@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2621/c483460528@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2621@github.com>
References: <quicwg/base-drafts/pull/2621@github.com>
Subject: Re: [quicwg/base-drafts] lost_pn can no longer be negative (#2621)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cb51a2c1f5ce_7af43f7f828d45b4606d4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ouUL6uaVN7OPgygwnDSWhIhgQ_4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Apr 2019 23:56:31 -0000

@ianswett: UINT64_MAX is commonly used as infinite. FWIW, I don't think it's a lot of complexity. Implementations have to handle special case conditions (such as initial state) anyways, and writing it down doesn't make implementations more complex.

Good point about 62 bits, but I'm generally wary of implementing PN as a signed int. You'd have to check for < 0 in all sorts of places then.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2621#issuecomment-483460528

v2.31.3 | Report a Bug | By Email | System Status