Re: [quicwg/base-drafts] Pseudocode fix: Data should be sent on loss-threshold timer (#2604)

ianswett <notifications@github.com> Thu, 11 April 2019 02:28 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B9E421200C7 for <quic-issues@ietfa.amsl.com>; Wed, 10 Apr 2019 19:28:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.597
X-Spam-Level:
X-Spam-Status: No, score=-6.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id duZX6VvwrUpL for <quic-issues@ietfa.amsl.com>; Wed, 10 Apr 2019 19:28:10 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 52E4D1200B2 for <quic-issues@ietf.org>; Wed, 10 Apr 2019 19:28:10 -0700 (PDT)
Date: Wed, 10 Apr 2019 19:28:09 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1554949689; bh=OvL4m9szQ3ga17LvrG2spPvQ5F+iGV2iuuWNvUPuI4E=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=0rF5GZgmK9ry6ium6hKFm4C4NrSzEiNG+p0KIBj54rQxc1M2oiwTnCnpMe5cXo0Tn fvwxn1mkOYtNBIQQ66HWN6BRIz8pgMuKG5bhHJCCJOSOQbAxN7AFOQZX8IMJtK1/ar 7T9JEocaKhDCIVfaS/kC00HYvMOYFWE9JRfR+Dbo=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab27fc266f2c4968ba071da0d4e9d5a97b3e1cd89292cebabbd8b992a169ce19b58a1d@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2604/481940778@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2604@github.com>
References: <quicwg/base-drafts/issues/2604@github.com>
Subject: Re: [quicwg/base-drafts] Pseudocode fix: Data should be sent on loss-threshold timer (#2604)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5caea639319a9_3e563fa0ad6d45c4155777"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ouYAOLp_ckY9TLadNLkIdrzADBo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Apr 2019 02:28:12 -0000

Ah, that makes sense, thanks for clarifying.

My first suggestion is "SendOneOrMorePacketsAsCongestionControlAllows()" which is insanely verbose.  An alternative is to say:

// Time threshold loss Detection
if (DetectLostPackets(pn_space)):
  // PRR allows immediately sending a packet
  SendOnePacket()
SendDataAsCwndAllows()

We don't reference PRR anywhere I can find in the existing recovery text.  Should we?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2604#issuecomment-481940778