Return-Path: X-Original-To: quic-issues@ietfa.amsl.com Delivered-To: quic-issues@ietfa.amsl.com Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2C4FF3A0C31 for ; Wed, 20 May 2020 09:17:56 -0700 (PDT) X-Virus-Scanned: amavisd-new at amsl.com X-Spam-Flag: NO X-Spam-Score: -1.555 X-Spam-Level: X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FpaWWllPBX3w for ; Wed, 20 May 2020 09:17:55 -0700 (PDT) Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D76943A0C27 for ; Wed, 20 May 2020 09:17:54 -0700 (PDT) Received: from github-lowworker-5825cd4.ac4-iad.github.net (github-lowworker-5825cd4.ac4-iad.github.net [10.52.22.68]) by smtp.github.com (Postfix) with ESMTP id 23B352C0B97 for ; Wed, 20 May 2020 09:17:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1589991474; bh=S0lsTW9xoOzZnksomHKz+FhGQAM+1nqRvpMVeICJT8s=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=SESx2qZtC7T2cMj4QWXz1ynP+ViSiP71B9EgjsK85LoBVnzgw/qfbHAbbG2L76mrr j9jg2EAGkzcQblej2urISu6GE/eYn7rOnN6tniMO+y2CE0jUU1KN1N82J5qDbgEGPM +Wz/nFlCr3BZ8JXOSWAKLFHW0eExTPktDvH52Lfo= Date: Wed, 20 May 2020 09:17:54 -0700 From: ianswett Reply-To: quicwg/base-drafts To: quicwg/base-drafts Cc: Subscribed Message-ID: In-Reply-To: References: Subject: Re: [quicwg/base-drafts] Split PTO calculation into a dedicated method (#3681) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5ec5583213515_110d3f984dacd968251994"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: ianswett X-GitHub-Recipient: quic-issues X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: quic-issues@ietf.org Archived-At: X-BeenThere: quic-issues@ietf.org X-Mailman-Version: 2.1.29 List-Id: Notification list for GitHub issues related to the QUIC WG List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 May 2020 16:17:56 -0000 ----==_mimepart_5ec5583213515_110d3f984dacd968251994 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit @ianswett commented on this pull request. > space = Initial for pn_space in [ Handshake, ApplicationData ]: - if (times[pn_space] != 0 && - (time == 0 || times[pn_space] < time) && - # Skip ApplicationData until handshake completion. - (pn_space != ApplicationData || - IsHandshakeComplete()): - time = times[pn_space]; + if (time == 0 || loss_time[pn_space] < time): + time = loss_times[pn_space]; ```suggestion time = loss_time[pn_space]; ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3681#pullrequestreview-415501201 ----==_mimepart_5ec5583213515_110d3f984dacd968251994 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

=0D

@ianswett commented on this pull request.

=0D =0D
=0D =0D

In draft-ietf-quic-recovery.md:

=0D 
>    space =3D Initial=0D
   for pn_space in [ Handshake, ApplicationData ]:=0D
-    if (times[pn_space] !=3D 0 &&=0D
-        (time =3D=3D 0 || times[pn_space] < time) &&=0D
-        # Skip ApplicationData until handshake completion.=0D
-        (pn_space !=3D ApplicationData ||=0D
-          IsHandshakeComplete()):=0D
-      time =3D times[pn_space];=0D
+    if (time =3D=3D 0 || loss_time[pn_space] < time):=0D
+      time =3D loss_times[pn_space];=0D
=0D =E2=AC=87=EF=B8=8F Suggested change=0D 
-      time =3D loss_times[pn_space];=0D
+      time =3D loss_time[pn_space];=0D
=0D =0D =0D

&m= dash;
You are receiving this because you are subscribed to this thre= ad.
Reply to this email directly, view it on GitHub, or unsubscribe.3D""

=0D = ----==_mimepart_5ec5583213515_110d3f984dacd968251994--