IETF Logo Mail Archive

Re: [quicwg/base-drafts] Rename Final Offset to Final Size (#2285)

Kazuho Oku <notifications@github.com> Sun, 06 January 2019 18:23 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 633E712875B for <quic-issues@ietfa.amsl.com>; Sun, 6 Jan 2019 10:23:09 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.064
X-Spam-Level:
X-Spam-Status: No, score=-8.064 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KYGGGTyggU1j for <quic-issues@ietfa.amsl.com>; Sun, 6 Jan 2019 10:23:07 -0800 (PST)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3EACE12894E for <quic-issues@ietf.org>; Sun, 6 Jan 2019 10:23:07 -0800 (PST)
Date: Sun, 06 Jan 2019 10:23:06 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1546798986; bh=s0AcVVMYtUKD2F3O5AcROlX4EOa7/j1pYA98a2L9bL0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=jyzk+ojNzQddVs0l9yU+X20iytPARZLAb9Go6P1WBLyrg2XcQLlORXD9Ks4VK4AAk 984Q2hSD0146kbV4gfTeHI98GRQ5S2IiHKCz+fOjOWB9kbQiqNlI8S+eNHxzRvm3Aq PgW+lk3v8mc2BBD7yGJeG7Miusk4lqdfHDW0OtY8=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab9335069a36df65c2853443e1f21ee956a78282a092cf00000001184a098a92a169ce1791b3a4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2285/review/189639291@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2285@github.com>
References: <quicwg/base-drafts/pull/2285@github.com>
Subject: Re: [quicwg/base-drafts] Rename Final Offset to Final Size (#2285)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c32478a4ff84_7b543f9bd38d45c4596240"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/p17jK9x3GnzI0mSgMbTa8s1eDxk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Jan 2019 18:23:09 -0000

kazuho commented on this pull request.



>  
-The final offset is the count of the number of bytes that are transmitted on a
-stream.  For a stream that is reset, the final offset is carried explicitly in a
-RESET_STREAM frame.  Otherwise, the final offset is the offset of the end of the
-data carried in a STREAM frame marked with a FIN flag, or 0 in the case of
-incoming unidirectional streams.
+The final size is the amount of flow control credit that is consumed by a
+stream.  Assuming that every contiguous byte on the stream was sent, the final

Thank you for the suggestion, applied in 5779ec1.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2285#discussion_r245517428

v2.23.0 | Report a Bug | By Email