IETF Logo Mail Archive

Re: [quicwg/base-drafts] Packet number echo with variable-length numbering (#391)

martinduke <notifications@github.com> Thu, 16 March 2017 15:16 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BEA41129577 for <quic-issues@ietfa.amsl.com>; Thu, 16 Mar 2017 08:16:25 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.796
X-Spam-Level:
X-Spam-Status: No, score=-9.796 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-2.796, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m43WVG0-HUv8 for <quic-issues@ietfa.amsl.com>; Thu, 16 Mar 2017 08:16:24 -0700 (PDT)
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2-ext1.iad.github.net [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C8975129576 for <quic-issues@ietf.org>; Thu, 16 Mar 2017 08:15:53 -0700 (PDT)
Date: Thu, 16 Mar 2017 08:15:53 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1489677353; bh=R651SkUkPUQ64X04+AdonMMSo2WxaCvhj0EXVdLbatg=; h=From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=m2rrKm2pMuEV5zStOX9kjb4CpFNMGZak3jlrKzVyk1yLQQYIijXS/wJBFKUZaslnW iHDX9HIH29Z3tLjCx7o2WlnecDnFrwxzGxZfm32UK13A7T5BQQTbb+rXQAo8x38J1/ Wj5T9auYi2D9J0RFlGyJ+cNS9i3q4oo8JWEG7Z3I=
From: martinduke <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab34d0a48c6f1d392efc5f3835792f68152b70117092cf0000000114e26e2992a169ce0cbd1e83@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/391/c287089666@github.com>
In-Reply-To: <quicwg/base-drafts/pull/391@github.com>
References: <quicwg/base-drafts/pull/391@github.com>
Subject: Re: [quicwg/base-drafts] Packet number echo with variable-length numbering (#391)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_58caac2929444_40993fbbd18c1c30293955"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinduke
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/p58vDx0jAWK9xHz5sQ8qyQrnrsc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Mar 2017 15:16:26 -0000

> In regards to reordering, the largest ack never decreases, even if packets are received out of order, so this should make decoding the value quite easy for middleboxes. 

I made this point quite unclearly in my comment. The annoying thing, implementation-wise, about option 2 is having to pass the header field all the way into ACK frame processing. What I was trying to say is that largest_acked is probably a PCB variable anyway, so header processing just writes the largest_acked value into the PCB and ACK processing can pull it from there.

If the ACK stream is reordered, I'm not going to rewrite pcb->largest_acked to a lower value. So I'm stuck passing the value down again. Not the end of the world, but just trying to address complexity.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/391#issuecomment-287089666

v2.37.1 | Report a Bug | By Email | System Status