IETF Logo Mail Archive

Re: [quicwg/base-drafts] ACK_ECN type value is not incremented (#1520)

Martin Thomson <notifications@github.com> Wed, 04 July 2018 09:10 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9A8BE130E2E for <quic-issues@ietfa.amsl.com>; Wed, 4 Jul 2018 02:10:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZJjpNuYoKekv for <quic-issues@ietfa.amsl.com>; Wed, 4 Jul 2018 02:10:42 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1DB51130E24 for <quic-issues@ietf.org>; Wed, 4 Jul 2018 02:10:42 -0700 (PDT)
Date: Wed, 04 Jul 2018 02:10:40 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1530695440; bh=IVHFzifbVR0vepHdQ1tPrP5dvnBtM3Dov48PHkCehKU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=LIQhbbrmsff9abRHsgm1UX2rcXkDaJc6Z2FQVFRHB7ndjnPBVuVhTegeUjKRPH6Wt GVulWajSwyx5MW/99VyNaKI670GKxnUX3FnZW72WwVO3C6Scp4NJksBo2CZV21MYiO cZFi16FXHb8t7M5bn+BpWsDXBCQR+2KTf5RE7taA=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab470f0b09a49ea2fbb5d55a51bf582b2c9f8a4a0f92cf000000011754511092a169ce14281420@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1520/review/134297754@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1520@github.com>
References: <quicwg/base-drafts/pull/1520@github.com>
Subject: Re: [quicwg/base-drafts] ACK_ECN type value is not incremented (#1520)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b3c8f10ec4fc_64273fe10777cf7c906e9"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/pBBb-upQH0xYpIbNpaK973rCl5k>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.26
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Jul 2018 09:10:44 -0000

martinthomson approved this pull request.

Probably best. This is the second time we (well, me mostly) have made this particular mistake. My only concern here is churn. Maybe we defer this fix and do a big rearrangement later. @janaiyengar, WDYT?



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1520#pullrequestreview-134297754

v2.29.0 | Report a Bug | By Email | System Status