Re: [quicwg/base-drafts] Relax requirement of detecting duplicate TPs on receiver (#2691)
ianswett <notifications@github.com> Tue, 14 May 2019 10:59 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 12A26120155 for <quic-issues@ietfa.amsl.com>; Tue, 14 May 2019 03:59:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.009
X-Spam-Level:
X-Spam-Status: No, score=-3.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id giKkCNaPNWKU for <quic-issues@ietfa.amsl.com>; Tue, 14 May 2019 03:59:33 -0700 (PDT)
Received: from out-22.smtp.github.com (out-22.smtp.github.com [192.30.252.205]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 95FEA12011C for <quic-issues@ietf.org>; Tue, 14 May 2019 03:59:33 -0700 (PDT)
Date: Tue, 14 May 2019 03:59:32 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1557831572; bh=FLYeH5FR67KlSeWQItMMwV4SBNByfceOFSGUC9s2OXY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=oj0Gs7wuvoa2aeuaE87WzVQgYe2JZrTQy2ZmeZCm8DE0y8Q5AEl2BwCi85mxeoLrL cP86oAsZeAbw60aPNl+BQ+UhVRXma7WLKyvH7/6DQgLApD3HZGT73hsT7hUpynIZIw EZlitJ7lu8RWYSull8mS1H9LGqMkTPqaQFPZnufI=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKYVPVYIDNJHT2V2QE5247JBJEVBNHHBUZV77I@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2691/review/237169946@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2691@github.com>
References: <quicwg/base-drafts/pull/2691@github.com>
Subject: Re: [quicwg/base-drafts] Relax requirement of detecting duplicate TPs on receiver (#2691)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cda9f944048c_29aa3fa0e8ccd96810685b4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/pCV-GRmnIQHnTUWMkQp9DT3ikCg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 May 2019 10:59:36 -0000
ianswett approved this pull request. > @@ -1379,12 +1379,14 @@ Once the handshake completes, the transport parameters declared by the peer are available. Each endpoint validates the value provided by its peer. Definitions for each of the defined transport parameters are included in -{{transport-parameter-definitions}}. An endpoint MUST treat receipt of a -transport parameter with an invalid value as a connection error of type -TRANSPORT_PARAMETER_ERROR. Any given parameter MUST appear at most once in a -given transport parameters extension. An endpoint MUST treat receipt of -duplicate transport parameters as a connection error of type -TRANSPORT_PARAMETER_ERROR. +{{transport-parameter-definitions}}. + +An endpoint MUST treat receipt of a transport parameter with an invalid value as +a connection error of type TRANSPORT_PARAMETER_ERROR. + +A parameter MUST NOT appear more than once in a given transport parameters This says "appear", but the conversation has been along the lines of "MUST NOT send" they mean the same, but "MUST NOT send" seems clearer to me, so I'd prefer it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2691#pullrequestreview-237169946
- [quicwg/base-drafts] Relax requirement of detecti… Jana Iyengar
- Re: [quicwg/base-drafts] Relax requirement of det… Dmitri Tikhonov
- Re: [quicwg/base-drafts] Relax requirement of det… Nick Banks
- Re: [quicwg/base-drafts] Relax requirement of det… ianswett
- Re: [quicwg/base-drafts] Relax requirement of det… Martin Thomson
- Re: [quicwg/base-drafts] Relax requirement of det… Mike Bishop
- Re: [quicwg/base-drafts] Relax requirement of det… martinduke
- Re: [quicwg/base-drafts] Relax requirement of det… martinduke
- Re: [quicwg/base-drafts] Relax requirement of det… David Schinazi
- Re: [quicwg/base-drafts] Relax requirement of det… Martin Thomson
- Re: [quicwg/base-drafts] Relax requirement of det… Kazuho Oku
- Re: [quicwg/base-drafts] Relax requirement of det… David Schinazi
- Re: [quicwg/base-drafts] Relax requirement of det… martinduke
- Re: [quicwg/base-drafts] Relax requirement of det… Lucas Pardue
- Re: [quicwg/base-drafts] Relax requirement of det… ianswett
- Re: [quicwg/base-drafts] Relax requirement of det… ianswett
- Re: [quicwg/base-drafts] Relax requirement of det… Jana Iyengar
- Re: [quicwg/base-drafts] Relax requirement of det… Jana Iyengar
- Re: [quicwg/base-drafts] Relax requirement of det… Kazuho Oku
- Re: [quicwg/base-drafts] Relax requirement of det… martinduke
- Re: [quicwg/base-drafts] Relax requirement of det… Jana Iyengar