Re: [quicwg/base-drafts] Rules for discarding old keys (#1636)

Mike Bishop <notifications@github.com> Wed, 08 August 2018 16:27 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 23E8A130ED7 for <quic-issues@ietfa.amsl.com>; Wed, 8 Aug 2018 09:27:07 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W-C0xmG4p2Ly for <quic-issues@ietfa.amsl.com>; Wed, 8 Aug 2018 09:27:05 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 72433130EEF for <quic-issues@ietf.org>; Wed, 8 Aug 2018 09:27:05 -0700 (PDT)
Date: Wed, 08 Aug 2018 09:27:04 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1533745624; bh=2ajflMr1McaaO8YUmq2/LeUHjdDVvuL3y2rpUS5XK6w=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=TXXXxW3o8FTKVTzANLQL+bcDO9pzYrc0cixm8c3YosZXIOobM83LFMDkAFukPjLQT XjYw7NKBS4fJnusTjinwHdcYx27BWINyaUpZ8wfIyehG1Gaa5GkZhmJMpOwdpy71NQ LLrL1WThzi3nBXan2J3rY2kUubPQULEqaoGewP60=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abec3c201dcf9fd74b33c831b26a2e72786e0ac2ab92cf000000011782dbd892a169ce14c102a5@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1636/review/144501735@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1636@github.com>
References: <quicwg/base-drafts/pull/1636@github.com>
Subject: Re: [quicwg/base-drafts] Rules for discarding old keys (#1636)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b6b19d875766_1d2d3fcf984d45c018173c"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/pEP7fYMcvXSUbnotH_Z1NT2ZzRg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Aug 2018 16:27:12 -0000

MikeBishop commented on this pull request.



>  encryption level are needed for a short time after keys for a newer encryption
 level are available.
 
-An endpoint can only discard keys for a given encryption level only after it has
-both received and acknowledged all CRYPTO frames for that encryption level and
-when it has had all CRYPTO frames for that encryption level acknowledged by its
+An endpoint cannot discard keys for a given encryption level unless it has both
+received and acknowledged all CRYPTO frames for that encryption level and when
+it all CRYPTO frames for that encryption level have been acknowledged by its

"and when ~it~ all"

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1636#pullrequestreview-144501735