Re: [quicwg/base-drafts] Seek more clarity on Largest Reference/Base Index encoding (#1403)

Martin Thomson <notifications@github.com> Fri, 01 June 2018 23:04 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0EE3112E03E for <quic-issues@ietfa.amsl.com>; Fri, 1 Jun 2018 16:04:05 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kB-S46YNoa2a for <quic-issues@ietfa.amsl.com>; Fri, 1 Jun 2018 16:04:03 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E367712E03C for <quic-issues@ietf.org>; Fri, 1 Jun 2018 16:04:02 -0700 (PDT)
Date: Fri, 01 Jun 2018 16:04:01 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1527894241; bh=0UJsPQqjd8Mj2gdW4dJnIB32yxrT47H96OF8RAFQHFA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=HNbACZ3soHfwBdLGHsCwHzFdJrZovS0bpNHypT1OjLyjA037qQwcnK7DWN0K7gpfC GkzqLxQOJHsTfgFXW8L5awpTcVH/Xrlv9cH/TQtJgCwb9EzCgOulKu5Drc0TIfW2uh vpQRHq/ZPoC7pxBlLBupFzEksMGGajGfa0JnyY4I=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab2b3505ec0656c8c60ec8ff3184dfd597f434f26792cf00000001172992e192a169ce1386190e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1403/review/125339214@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1403@github.com>
References: <quicwg/base-drafts/pull/1403@github.com>
Subject: Re: [quicwg/base-drafts] Seek more clarity on Largest Reference/Base Index encoding (#1403)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b11d0e1deba6_40b03f87265b8f78638546"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/pNHkKdrA6g_qZeZwhLXLsM49YnM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Jun 2018 23:04:05 -0000

martinthomson commented on this pull request.



>  
-    baseIndex = largestReference + deltaBaseIndex
+To save space, Base Index is encoded relative to Largest Reference using a
+one-bit sign and the `Delta Base Index` value.  A sign bit of 0 indicates that
+the Base Index has a greater absolute index than the Largest Reference; the

Well the sentence says that the encoder added entries.  I don't think that it's a problem to not mention the zero case.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1403#discussion_r192534196