Re: [quicwg/base-drafts] Awkward text in "Sending Probe Packets" (#2493)
ianswett <notifications@github.com> Mon, 15 April 2019 16:04 UTC
Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8A9A21203D6 for <quic-issues@ietfa.amsl.com>; Mon, 15 Apr 2019 09:04:08 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.597
X-Spam-Level:
X-Spam-Status: No, score=-1.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kgGBcuAZqQrL for <quic-issues@ietfa.amsl.com>; Mon, 15 Apr 2019 09:04:06 -0700 (PDT)
Received: from o5.sgmail.github.com (o5.sgmail.github.com [192.254.113.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 807691203BF for <quic-issues@ietf.org>; Mon, 15 Apr 2019 09:04:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=Cpk+3PEpN9posrBPAUcHRDLLKzU=; b=Xvm6jtvPzrBkOw1M 3pkGl4Y/MhmyvfV+SFY9v6y2YzHiaPRw5rFnP+WX4gTZcY4yPywL/ZwJe85ytPUT fMALtPZT+2IaodDHeVPtnurHc+uDcvQzgaNzc1N47cYevBiIDi5kdZNl7n6B1Oow 3/341pZSbr1mfLB+w2C3oG19zrs=
Received: by filter1457p1mdw1.sendgrid.net with SMTP id filter1457p1mdw1-31519-5CB4AB75-A 2019-04-15 16:04:05.099499765 +0000 UTC m=+345627.613530020
Received: from github-lowworker-cb75ac4.cp1-iad.github.net (unknown [192.30.252.40]) by ismtpd0038p1iad2.sendgrid.net (SG) with ESMTP id mtLQcunkQJq2TNuoqFQRXQ for <quic-issues@ietf.org>; Mon, 15 Apr 2019 16:04:05.036 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-cb75ac4.cp1-iad.github.net (Postfix) with ESMTP id 07969C203C1 for <quic-issues@ietf.org>; Mon, 15 Apr 2019 09:04:05 -0700 (PDT)
Date: Mon, 15 Apr 2019 16:04:05 +0000
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab0cd492d50621848773e90c0aae2e8e8b1dca04ce92cebac1ddf592a169ce18ca0231@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2493/483314934@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2493@github.com>
References: <quicwg/base-drafts/issues/2493@github.com>
Subject: Re: [quicwg/base-drafts] Awkward text in "Sending Probe Packets" (#2493)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cb4ab755be9_9f23fd56aed45c018692d"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2Yo95cjcJzJYXP0eyvjNVVeGrURXJzdJkW2o wKQ2NY538qSRqtUhG1uTDwTDJVjuGdIDI4TcQm9y00FLM1MUVe0N2EO5OTDObLGQlGrf4RoIstcPWE F6fo+1tXwfCT4YQL09vX3jR0OgeM1MYoN4Mt7aCBkNZQvKi8116pWScb46eoQYKLpkDmXGuZZw1DpG E=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/pRs_p9LDjaSBztbAkr0RTHzOFZE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Apr 2019 16:04:08 -0000
The pseudocode now uses SendOneOrTwoPackets(), but the last paragraph pretty clearly violates the previous MUST, which is very bad. The simplest fix would be to change the MUST to a "SHOULD unless otherwise specified", but I'm increasingly thinking we should stick with the MUST and if you get into a situation you have nothing to send, require sending something ack-eliciting to ensure in-flight packets are removed from flight. Thoughts? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/issues/2493#issuecomment-483314934