Re: [quicwg/base-drafts] Go Back to Single Packet Number Space (#1579)

Nick Banks <notifications@github.com> Tue, 17 July 2018 20:57 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 78F83130DD2 for <quic-issues@ietfa.amsl.com>; Tue, 17 Jul 2018 13:57:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.01
X-Spam-Level:
X-Spam-Status: No, score=-8.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fPVyuGp9LCfr for <quic-issues@ietfa.amsl.com>; Tue, 17 Jul 2018 13:57:54 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7EFD8130DC2 for <quic-issues@ietf.org>; Tue, 17 Jul 2018 13:57:54 -0700 (PDT)
Date: Tue, 17 Jul 2018 13:57:53 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1531861073; bh=FUyzbntd8Ocyuh2jZ8U7761crDPQ88ZgKuvyrcLRBrE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=TnEje/w7FLGZkQUQkec8f8SaTFG5R2+uF0gdUru9v4SFVVc/LZg+iqRRUp9Oujpc7 yV2JGuD7bzqik9GkinjbyneCIUrZtBHZlaLhE5LPLQf8JfXfKAchY2mylhkz7hG2M/ raYpUCQTufwFhiL0NIDldJAz0jSpcGv78PxVMzFs=
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abe7a8891425cdbbeae1e08e94ac4dcb170183452592cf0000000117661a5192a169ce14638397@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1579/405725492@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1579@github.com>
References: <quicwg/base-drafts/issues/1579@github.com>
Subject: Re: [quicwg/base-drafts] Go Back to Single Packet Number Space (#1579)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b4e5851de449_24f92b0e248eaf502571e2"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/pTrj3GdJtmTmO5azmu2rlX4DYmo>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Jul 2018 20:57:57 -0000

1. Reserve 2 bits per sent packet tracking structure for encryption level. I'd bet whatever structure you have already has 2 free bits.
2. When processing an ACK frame, pass along the encryption level the frame was received in. Use that in your `OnPacketAcked` function to validate.

That logic was a LOT simpler than the logic I have to maintain for framing all my ACKs in the different packet levels right now.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1579#issuecomment-405725492